Paths

Table of Contentst

Differential D17002

[Cashtab] Do not render empty parentheses for tickerless tokens in tx history
ClosedPublic
Actions

Authored by bytesofman on Fri, Oct 25, 12:47.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC0bcd36ce0be8: [Cashtab] Do not render empty parentheses for tickerless tokens in tx history

Summary

If a token has no ticker, do not render "()"

Test Plan

npm test

I don't think it's worth adding a new mock to test this.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

no-empty-tickers

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30838
Build 61189: Build Diff	cashtab-tests
Build 61188: arc lint + arc unit

Event Timeline

bytesofman created this revision.Fri, Oct 25, 12:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Oct 25, 12:47

bytesofman edited the test plan for this revision. (Show Details)Fri, Oct 25, 12:53

Harbormaster completed remote builds in B30838: Diff 50433.Fri, Oct 25, 13:05

bytesofman published this revision for review.Sun, Oct 27, 18:26

Fabien accepted this revision.Sun, Oct 27, 19:55

This revision is now accepted and ready to land.Sun, Oct 27, 19:55

Closed by commit rABC0bcd36ce0be8: [Cashtab] Do not render empty parentheses for tickerless tokens in tx history (authored by bytesofman). · Explain WhySun, Oct 27, 20:13

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC0bcd36ce0be8: [Cashtab] Do not render empty parentheses for tickerless tokens in tx history.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Home/

Tx/

index.js

4 lines

Diff 50433

View Options

cashtab/src/components/Home/Tx/index.js

[Cashtab] Do not render empty parentheses for tickerless tokens in tx historyClosedPublicActions