Paths

Table of Contentst

Differential D17050

[token-server] Patch bug in token validation function
ClosedPublic
Actions

Authored by bytesofman on Thu, Oct 31, 10:34.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCc2795be8090d: [token-server] Patch bug in token validation function

Summary

Need anchors in regex for length to be properly checked.

Patch, and patch the test vectors that "tested" this with the wrong values.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

token-server-patch-fn

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30935
Build 61373: Build Diff	token-server-tests
Build 61372: arc lint + arc unit

Event Timeline

bytesofman created this revision.Thu, Oct 31, 10:34

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Oct 31, 10:34

bytesofman published this revision for review.Thu, Oct 31, 10:34

Harbormaster completed remote builds in B30935: Diff 50570.Thu, Oct 31, 10:36

emack accepted this revision.Thu, Oct 31, 12:04

This revision is now accepted and ready to land.Thu, Oct 31, 12:04

Closed by commit rABCc2795be8090d: [token-server] Patch bug in token validation function (authored by bytesofman). · Explain WhyThu, Oct 31, 12:50

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCc2795be8090d: [token-server] Patch bug in token validation function.

Revision Contents
Changeset List

Path

Size

apps/

token-server/

src/

validation.ts

2 lines

test/

vectors.ts

10 lines

Diff 50570

View Options

apps/token-server/src/validation.ts