[Cashtab] Lint GoogleAnalytics.js
ClosedPublic
Actions

Authored by bytesofman on Thu, Oct 31, 18:03.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABCcd1d35645a2b: [Cashtab] Lint GoogleAnalytics.js

Summary

This came up when upgrading the linter to support ts. Not really related to the ts implementation. Keep in own diff.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

lint-ga

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 30948
Build 61399: Build Diff	cashtab-tests
Build 61398: arc lint + arc unit

Event Timeline

bytesofman created this revision.Thu, Oct 31, 18:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Oct 31, 18:03

bytesofman published this revision for review.Thu, Oct 31, 18:04

Harbormaster completed remote builds in B30948: Diff 50587.Thu, Oct 31, 18:07

emack accepted this revision.Fri, Nov 1, 00:06

This revision is now accepted and ready to land.Fri, Nov 1, 00:06

Closed by commit rABCcd1d35645a2b: [Cashtab] Lint GoogleAnalytics.js (authored by bytesofman). · Explain WhyFri, Nov 1, 13:07

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCcd1d35645a2b: [Cashtab] Lint GoogleAnalytics.js.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Common/

GoogleAnalytics.js

4 lines

Diff 50587

View Options

cashtab/src/components/Common/GoogleAnalytics.js

[Cashtab] Lint GoogleAnalytics.jsClosedPublicActions