Page MenuHomePhabricator
Differential D17109

net: Replace enum CConnMan::NumConnections with enum class ConnectionDirection
ClosedPublic
Actions

Authored by PiRK on Tue, Nov 12, 11:34.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC5df861c9c822: net: Replace enum CConnMan::NumConnections with enum class ConnectionDirection
Summary

This is a backport of core#19771

Test Plan

ninja all check-all bitcoin-fuzzers

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Tue, Nov 12, 11:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Nov 12, 11:34
PiRK requested review of this revision.Tue, Nov 12, 11:34
teamcity edited the summary of this revision. (Show Details)Tue, Nov 12, 11:34
Harbormaster completed remote builds in B31084: Diff 50778.Tue, Nov 12, 12:13
PiRK added a child revision: D17110: net: Add CNodeOptions and increase constness.Tue, Nov 12, 13:16
Fabien accepted this revision.Tue, Nov 12, 13:53
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/interfaces/node.h
9 ↗(On Diff #50778)

This is the evidence that these comments are bad... they're never maintained

This revision is now accepted and ready to land.Tue, Nov 12, 13:53
Closed by commit rABC5df861c9c822: net: Replace enum CConnMan::NumConnections with enum class ConnectionDirection (authored by Luke Dashjr <luke-jr+git@utopios.org>, committed by PiRK). · Explain WhyTue, Nov 12, 16:14
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC5df861c9c822: net: Replace enum CConnMan::NumConnections with enum class ConnectionDirection.

Revision Contents
Changeset List

PathSize
src/
avalanche/
3 lines
interfaces/
5 lines
10 lines
8 lines
20 lines
node/
2 lines
qt/
8 lines
rpc/
2 lines
10 lines
test/
fuzz/
5 lines

Diff 50792

View Options

src/avalanche/processor.cpp

Loading...
View Options

src/interfaces/node.h

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/netbase.h

Loading...
View Options

src/node/interfaces.cpp

Loading...
View Options

src/qt/clientmodel.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/rpc/net.cpp

Loading...
View Options

src/test/fuzz/connman.cpp

Loading...