Page MenuHomePhabricator
Differential D17114

p2p: Allow whitelisting manual connections
ClosedPublic
Actions

Authored by PiRK on Tue, Nov 12, 14:25.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC0e905bbfc0af: p2p: Allow whitelisting manual connections
Summary

net: store -whitelist{force}relay values in CConnman

net: Move NetPermissionFlags::Implicit verification to AddWhitelistPermissionFlags

net_processing: Move extra service flag into InitializeNode

Accept "in" and "out" flags to -whitelist to allow whitelisting manual connections

test: add coverage for whitelisting manual connections

This is a partial backport of core#27114
https://github.com/bitcoin/bitcoin/pull/27114/commits/2863d7dddb62d987b3e1c3b8bfad7083f0f774b2
https://github.com/bitcoin/bitcoin/pull/27114/commits/9133fd69a5cc9a0ab1a06a60d09f1b7e1039018e
https://github.com/bitcoin/bitcoin/pull/27114/commits/8e06be347c5e14cbe75256eba170e0867f95f360
https://github.com/bitcoin/bitcoin/pull/27114/commits/66bc6e2d1749f43d7b314aa2784a06af78440170
https://github.com/bitcoin/bitcoin/pull/27114/commits/e6b8f19de9a6d1c477d0bbda18d17794cd81a6f4
https://github.com/bitcoin/bitcoin/pull/27114/commits/0a533613fb44207053796fd01a9f4b523a3153d4

Depends on D17112
Note that CNode::m_permissionFlags was made public by core in core#20881 which we are missing so it had to be made public in this diff.

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Tue, Nov 12, 14:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Nov 12, 14:25
PiRK requested review of this revision.Tue, Nov 12, 14:25
teamcity edited the summary of this revision. (Show Details)Tue, Nov 12, 14:25
PiRK added a child revision: D17115: test: add option to speed up tx relay/mempool sync.Tue, Nov 12, 14:28
Fabien requested changes to this revision.Tue, Nov 12, 14:39
Fabien added a subscriber: Fabien.
Fabien added inline comments.
doc/release-notes.md
10 ↗(On Diff #50783)

Macro newlinebernie:

src/init.cpp
972–973 ↗(On Diff #50783)
This revision now requires changes to proceed.Tue, Nov 12, 14:39
Harbormaster completed remote builds in B31089: Diff 50783.Tue, Nov 12, 14:43
PiRK updated this revision to Diff 50788.Tue, Nov 12, 14:55

feedback

Harbormaster completed remote builds in B31094: Diff 50788.Tue, Nov 12, 15:15
Fabien accepted this revision.Tue, Nov 12, 15:39
This revision is now accepted and ready to land.Tue, Nov 12, 15:39
Closed by commit rABC0e905bbfc0af: p2p: Allow whitelisting manual connections (authored by brunoerg <brunoely.gc@gmail.com>, committed by PiRK). · Explain WhyTue, Nov 12, 16:14
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC0e905bbfc0af: p2p: Allow whitelisting manual connections.

Revision Contents
Changeset List

PathSize
doc/
4 lines
src/
36 lines
38 lines
62 lines
10 lines
44 lines
6 lines
test/
fuzz/
3 lines
18 lines
test/
functional/
14 lines

Diff 50796

View Options

doc/release-notes.md

Loading...
View Options

src/init.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_permissions.h

Loading...
View Options

src/net_permissions.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/test/fuzz/net_permissions.cpp

Loading...
View Options

src/test/netbase_tests.cpp

Loading...
View Options

test/functional/p2p_permissions.py

Loading...