Page MenuHomePhabricator
Differential D17147

util: Introduce ToIntegral<T>(const std::string&) for locale independent parsing using std::from_chars(…) (C++17)
ClosedPublic
Actions

Authored by PiRK on Nov 16 2024, 09:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC10326d3320e1: util: Introduce ToIntegral<T>(const std::string&) for locale independent…
Summary

util: Avoid locale dependent functions strtol/strtoll/strtoul/strtoull in ParseInt32/ParseInt64/ParseUInt32/ParseUInt64

fuzz: Assert equivalence between new and old Parse{Int,Uint}{8,32,64} functions

test: Add unit tests for ToIntegral<T>(const std::string&)

refactor: Remove unused ParsePrechecks from ParseIntegral

Also:

  • Remove redundant {} from return statement
  • Add missing failing c-string test case and "-" and "+" strings
  • Add missing failing test cases for non-int32_t integral types

Remove unused ParseDouble and ParsePrechecks

This is a backport of core#20457 and core#23156

Test Plan

ninja all check-all bitcoin-fuzzers

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 16 2024, 09:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2024, 09:20
PiRK requested review of this revision.Nov 16 2024, 09:20
teamcity edited the summary of this revision. (Show Details)Nov 16 2024, 09:21
PiRK planned changes to this revision.Nov 16 2024, 09:34
PiRK added inline comments.
src/test/fuzz/string.cpp
108 ↗(On Diff #50884)

I missed the braces formatting one, will fix after clang-tidy is done complaining.

Harbormaster completed remote builds in B31162: Diff 50884.Nov 16 2024, 09:39
PiRK updated this revision to Diff 50885.Nov 16 2024, 10:31

it didn't complain but fix it anyway

PiRK added a child revision: D17148: Make strencodings functions use string_view.Nov 16 2024, 10:32
Harbormaster completed remote builds in B31163: Diff 50885.Nov 16 2024, 10:52
Fabien accepted this revision.Nov 18 2024, 09:16
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/init.cpp
1380 ↗(On Diff #50885)
This revision is now accepted and ready to land.Nov 18 2024, 09:16
PiRK updated this revision to Diff 50919.Nov 18 2024, 09:29

comment nits

Harbormaster completed remote builds in B31180: Diff 50919.Nov 18 2024, 09:49
Closed by commit rABC10326d3320e1: util: Introduce ToIntegral<T>(const std::string&) for locale independent… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by PiRK). · Explain WhyNov 18 2024, 10:22
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC10326d3320e1: util: Introduce ToIntegral<T>(const std::string&) for locale independent….

Revision Contents
Changeset List

PathSize
arcanist/
linter/
9 lines
src/
avalanche/
16 lines
4 lines
test/
fuzz/
3 lines
166 lines
120 lines
util/
29 lines
137 lines

Diff 50922

View Options

arcanist/linter/LocaleDependenceLinter.php

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/test/fuzz/parse_numbers.cpp

Loading...
View Options

src/test/fuzz/string.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/util/strencodings.h

Loading...
View Options

src/util/strencodings.cpp

Loading...