Page MenuHomePhabricator
Differential D17148

Make strencodings functions use string_view
ClosedPublic
Actions

Authored by PiRK on Nov 16 2024, 10:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCdad4fd9df468: Make strencodings functions use string_view
Summary

Make ParseHex use string_view

https://github.com/bitcoin/bitcoin/pull/25001/commits/c1d165a8c2678c31aced5e1d46231d9996b0774a

Make IsHex use string_view

https://github.com/bitcoin/bitcoin/pull/25001/commits/40062997f223d88d4f92aaae4622a31476686163

Make IsHexNumber use string_view

https://github.com/bitcoin/bitcoin/pull/25001/commits/963bc9b576f0a62caffede2ce32830aef3473995

Make SanitizeString use string_view

https://github.com/bitcoin/bitcoin/pull/25001/commits/d648b5120b2fefa9e599898bd26f05ecf4428fac

This is a partial backport of core#25001

Depends on D17147

Test Plan

ninja all check-all bitcoin-fuzzers

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Nov 16 2024, 10:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 16 2024, 10:32
PiRK requested review of this revision.Nov 16 2024, 10:32
teamcity edited the summary of this revision. (Show Details)Nov 16 2024, 10:32
PiRK added a child revision: D17149: modernize DecodeBase{32,64}, reject incorrect base64 in HTTP auth.Nov 16 2024, 10:34
Harbormaster completed remote builds in B31164: Diff 50886.Nov 16 2024, 10:38
teamcity added a comment.Nov 16 2024, 10:38
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[379/575] Linking C executable src/secp256k1/internal-bench
[380/575] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[381/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[382/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[383/575] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[384/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[385/575] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[386/575] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[387/575] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[388/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[389/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[390/575] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[391/575] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[392/575] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[393/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[394/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[395/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[396/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[397/575] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[398/575] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[399/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[400/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[401/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[402/575] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[403/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[404/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[405/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[406/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[407/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[408/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[409/575] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[410/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[411/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[412/575] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[413/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[414/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[415/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[416/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[417/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[418/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[419/575] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[420/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[421/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[422/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[423/575] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[424/575] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[425/575] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[426/575] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[427/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[428/575] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[429/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[430/575] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[431/575] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[432/575] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[433/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[434/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[435/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[436/575] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
PiRK updated this revision to Diff 50891.Nov 16 2024, 10:46

fix clang-tidy

Harbormaster completed remote builds in B31169: Diff 50891.Nov 16 2024, 11:40
Fabien accepted this revision.Nov 18 2024, 09:34
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/util/strencodings.cpp
73 ↗(On Diff #50891)

nice

This revision is now accepted and ready to land.Nov 18 2024, 09:34
Closed by commit rABCdad4fd9df468: Make strencodings functions use string_view (authored by Pieter Wuille <pieter@wuille.net>, committed by PiRK). · Explain WhyNov 18 2024, 10:23
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCdad4fd9df468: Make strencodings functions use string_view.

Revision Contents
Changeset List

PathSize
src/
util/
10 lines
56 lines

Diff 50923

View Options

src/util/strencodings.h

Loading...
View Options

src/util/strencodings.cpp

Loading...