Page MenuHomePhabricator
Differential D17167

[chronik] updated dependencies - Cargo.lock
ClosedPublic
Actions

Authored by hazzarust on Nov 20 2024, 12:47.

Details

Reviewers
tobias_ruck
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC10076c2a2034: [chronik] updated dependencies - Cargo.lock
Summary

Submitting Cargo.lock before making changes to dependencies to keep everything clean.

Test Plan

ninja check-functional

Diff Detail

Event Timeline

hazzarust created this revision.Nov 20 2024, 12:47
Owners added a reviewer: Restricted Owners Package.Nov 20 2024, 12:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 20 2024, 12:47
hazzarust requested review of this revision.Nov 20 2024, 12:47
Harbormaster completed remote builds in B31217: Diff 50974.Nov 20 2024, 12:47
tobias_ruck requested changes to this revision.Nov 20 2024, 12:49
tobias_ruck added a subscriber: tobias_ruck.

the title is wrong (the file was already there) and the test plan too (missing -)

This revision now requires changes to proceed.Nov 20 2024, 12:49
tobias_ruck added a comment.Nov 20 2024, 12:50

@bot build-chronik-plugins

teamcity awarded a token.Nov 20 2024, 12:50
hazzarust updated this revision to Diff 50975.Nov 20 2024, 12:52
hazzarust retitled this revision from Added cargo.lock to cargo.lock.
hazzarust edited the summary of this revision. (Show Details)
hazzarust edited the test plan for this revision. (Show Details)

Renamed title and updated test name

Harbormaster completed remote builds in B31218: Diff 50975.Nov 20 2024, 12:52
hazzarust retitled this revision from cargo.lock to updating dependencies - cargo.lock.Nov 20 2024, 13:26
hazzarust edited the summary of this revision. (Show Details)
hazzarust edited the summary of this revision. (Show Details)Nov 20 2024, 13:49
hazzarust retitled this revision from updating dependencies - cargo.lock to updated dependencies - cargo.lock.Nov 20 2024, 13:59
hazzarust edited the summary of this revision. (Show Details)
hazzarust retitled this revision from updated dependencies - cargo.lock to updated dependencies - Cargo.lock.Nov 20 2024, 15:02
hazzarust edited the summary of this revision. (Show Details)
hazzarust updated this revision to Diff 51088.Mon, Nov 25, 02:21
hazzarust edited the summary of this revision. (Show Details)

Pushed changes in D17197 before pushing this change

Harbormaster completed remote builds in B31307: Diff 51088.Mon, Nov 25, 03:04
Fabien accepted this revision.Mon, Nov 25, 07:38
Fabien retitled this revision from updated dependencies - Cargo.lock to [chronik] updated dependencies - Cargo.lock.
Fabien added a subscriber: Fabien.

We usually prefix the diff titles with the context project when it's relevant, in this case we would prefix with [chronik]. It just makes it clear at first sight what dependencies you're changing. I went ahead and edited accordingly.

tobias_ruck accepted this revision.Mon, Nov 25, 11:14
This revision is now accepted and ready to land.Mon, Nov 25, 11:14
Closed by commit rABC10076c2a2034: [chronik] updated dependencies - Cargo.lock (authored by hazzarust). · Explain WhyThu, Nov 28, 23:38
This revision was automatically updated to reflect the committed changes.
hazzarust added a commit: rABC10076c2a2034: [chronik] updated dependencies - Cargo.lock.

Revision Contents
Changeset List

PathSize

Diff 51088

View Options

Cargo.lock

Loading...