Page MenuHomePhabricator
Differential D17283

[test] Only sync proofs when avalanche is enabled
ClosedPublic
Actions

Authored by Fabien on Tue, Dec 3, 10:48.

Details

Reviewers
PiRK
tobias_ruck
Group Reviewers
Restricted Project
Commits
rABC5fad806b05e1: [test] Only sync proofs when avalanche is enabled
Summary

This makes it possible to use the functional test framework with avalanche disabled nodes.
Since the nodes are synced by default upon startup, all the tests currently would fail without this change except abc_rpc_getinfo. The flag order reversal in this test would cause it to fail as well on master but it succeeds after this patch.

Depends on D17282.

Test Plan
./test/functional/test_runner.py abc_rpc_getinfo

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Tue, Dec 3, 10:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Dec 3, 10:48
Fabien requested review of this revision.Tue, Dec 3, 10:48
Harbormaster completed remote builds in B31498: Diff 51362.Tue, Dec 3, 11:09
Fabien updated this revision to Diff 51367.Tue, Dec 3, 13:21

Rebase

PiRK accepted this revision.Tue, Dec 3, 13:23
This revision is now accepted and ready to land.Tue, Dec 3, 13:23
tobias_ruck accepted this revision.Tue, Dec 3, 13:25
tobias_ruck added a subscriber: tobias_ruck.
tobias_ruck added inline comments.
test/functional/test_framework/test_framework.py
807 ↗(On Diff #51367)

=== true

810 ↗(On Diff #51367)

Optional, I’ve seen linters suggest this in the past

This revision was landed with ongoing or failed builds.Tue, Dec 3, 13:28
Closed by commit rABC5fad806b05e1: [test] Only sync proofs when avalanche is enabled (authored by Fabien). · Explain Why
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC5fad806b05e1: [test] Only sync proofs when avalanche is enabled.
Harbormaster completed remote builds in B31502: Diff 51367.Tue, Dec 3, 13:43

Revision Contents
Changeset List

PathSize
test/
functional/
8 lines
test_framework/
12 lines

Diff 51370

View Options

test/functional/abc_rpc_getinfo.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...