Page MenuHomePhabricator
Differential D1729

Nits in httpserver
ClosedPublic
Actions

Authored by jasonbcox on Sep 6 2018, 14:54.

Details

Reviewers
deadalnix
Mengerian
Group Reviewers
Restricted Project
Commits
rSTAGING84a4b7836544: Nits in httpserver
rABC84a4b7836544: Nits in httpserver
Summary

See title

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Sep 6 2018, 14:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2018, 14:54
teamcity added a subscriber: teamcity.Sep 6 2018, 14:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 6 2018, 15:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3214: Diff 4790.Sep 6 2018, 15:30
deadalnix requested changes to this revision.Sep 6 2018, 16:33
deadalnix added inline comments.
src/httpserver.cpp
406 ↗(On Diff #4790)

This should be kept, this is a legit comment.

414 ↗(On Diff #4790)

dito

This revision now requires changes to proceed.Sep 6 2018, 16:33
jasonbcox added inline comments.Sep 6 2018, 19:07
src/httpserver.cpp
406 ↗(On Diff #4790)

I'll just remove the XXX then. It's dumb and shows up highlighted in vim :P

jasonbcox updated this revision to Diff 4803.Sep 6 2018, 19:11

Fixed RAII comments

jasonbcox marked 3 inline comments as done.Sep 6 2018, 19:11
teamcity added a comment.Sep 6 2018, 19:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 6 2018, 19:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3222: Diff 4803.Sep 6 2018, 19:50
deadalnix added inline comments.Sep 6 2018, 22:29
src/httpserver.cpp
406 ↗(On Diff #4790)

https://softwareengineering.stackexchange.com/a/65470

jasonbcox updated this revision to Diff 4809.Sep 6 2018, 22:45

Added back XXX. lol

teamcity added a comment.Sep 6 2018, 22:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Sep 6 2018, 22:46
This revision is now accepted and ready to land.Sep 6 2018, 22:46
teamcity added a comment.Sep 6 2018, 23:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3224: Diff 4809.Sep 6 2018, 23:22
Closed by commit rABC84a4b7836544: Nits in httpserver (authored by jasonbcox). · Explain WhySep 6 2018, 23:31
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
45 lines
21 lines

Diff 4810

View Options

src/httpserver.h

Loading...
View Options

src/httpserver.cpp

Loading...