Page MenuHomePhabricator

Nits in httpserver
ClosedPublic

Authored by jasonbcox on Sep 6 2018, 14:54.

Details

Summary

See title

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
httpnits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3222
Build 4531: Bitcoin ABC Buildbot (legacy)
Build 4530: arc lint + arc unit

Event Timeline

deadalnix requested changes to this revision.Sep 6 2018, 16:33
deadalnix added inline comments.
src/httpserver.cpp
406 ↗(On Diff #4790)

This should be kept, this is a legit comment.

414 ↗(On Diff #4790)

dito

This revision now requires changes to proceed.Sep 6 2018, 16:33
src/httpserver.cpp
406 ↗(On Diff #4790)

I'll just remove the XXX then. It's dumb and shows up highlighted in vim :P

This revision is now accepted and ready to land.Sep 6 2018, 22:46
This revision was automatically updated to reflect the committed changes.