Differential D1730

[Wallet] Add RPC call "rescanblockchain <startheight> <stopheight>"
ClosedPublic
Actions

Authored by deadalnix on Sep 6 2018, 15:37.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGfa795ffea08c: [Wallet] Add RPC call "rescanblockchain <startheight> <stopheight>"
rABCfa795ffea08c: [Wallet] Add RPC call "rescanblockchain <startheight> <stopheight>"

Summary

Backport core PR7061

[Wallet] add rescanblockchain <start_height> <stop_height> RPC command
[QA] Add RPC based rescan test

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 6 2018, 15:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2018, 15:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3215: Diff 4793.Sep 6 2018, 16:13

jasonbcox requested changes to this revision.Sep 6 2018, 20:55

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

test/functional/timing.json
7 ↗	(On Diff #4793)	This should be a separate diff.
test/functional/wallet-hd.py
116 ↗	(On Diff #4793)	Needs a test case for just the start param. ie. rescanblockchain(1)

This revision now requires changes to proceed.Sep 6 2018, 20:55

deadalnix added inline comments.Sep 10 2018, 14:42

test/functional/timing.json
7 ↗	(On Diff #4793)	No, regenerating these when adding new intergation tests is definitively required. A bot doing it automagically would be better, however :)

Add missing test cases

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3247: Diff 4839.Sep 10 2018, 15:24

jasonbcox accepted this revision.Sep 17 2018, 22:25

This revision is now accepted and ready to land.Sep 17 2018, 22:25

Closed by commit rABCfa795ffea08c: [Wallet] Add RPC call "rescanblockchain <startheight> <stopheight>" (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by deadalnix). · Explain WhySep 17 2018, 22:26

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

qt/

test/

wallettests.cpp

2 lines

rpc/

2 lines

wallet/

84 lines

test/

wallet_tests.cpp

6 lines

1 line

15 lines

test/

functional/

140 lines

32 lines

Diff 4957

src/qt/test/wallettests.cpp

Loading...

src/rpc/client.cpp

Loading...

src/wallet/rpcwallet.cpp

Loading...

src/wallet/test/wallet_tests.cpp

Loading...

src/wallet/wallet.h

Loading...

src/wallet/wallet.cpp

Loading...

test/functional/timing.json

Loading...

test/functional/wallet-hd.py

Loading...