Page MenuHomePhabricator

[Wallet] Add RPC call "rescanblockchain <startheight> <stopheight>"
ClosedPublic

Authored by deadalnix on Sep 6 2018, 15:37.

Details

Summary

Backport core PR7061

[Wallet] add rescanblockchain <start_height> <stop_height> RPC command
[QA] Add RPC based rescan test

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
corepr7061
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3247
Build 4581: Bitcoin ABC Buildbot (legacy)
Build 4580: arc lint + arc unit

Event Timeline

jasonbcox requested changes to this revision.Sep 6 2018, 20:55
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/timing.json
7 ↗(On Diff #4793)

This should be a separate diff.

test/functional/wallet-hd.py
116 ↗(On Diff #4793)

Needs a test case for just the start param. ie. rescanblockchain(1)

This revision now requires changes to proceed.Sep 6 2018, 20:55
test/functional/timing.json
7 ↗(On Diff #4793)

No, regenerating these when adding new intergation tests is definitively required.

A bot doing it automagically would be better, however :)

This revision is now accepted and ready to land.Sep 17 2018, 22:25
This revision was automatically updated to reflect the committed changes.