Page MenuHomePhabricator
Differential D1730

[Wallet] Add RPC call "rescanblockchain <startheight> <stopheight>"
ClosedPublic
Actions

Authored by deadalnix on Sep 6 2018, 15:37.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGfa795ffea08c: [Wallet] Add RPC call "rescanblockchain <startheight> <stopheight>"
rABCfa795ffea08c: [Wallet] Add RPC call "rescanblockchain <startheight> <stopheight>"
Summary

Backport core PR7061

[Wallet] add rescanblockchain <start_height> <stop_height> RPC command
[QA] Add RPC based rescan test

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
corepr7061
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3247
Build 4581: Bitcoin ABC Buildbot (legacy)
Build 4580: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 6 2018, 15:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2018, 15:37
teamcity added a subscriber: teamcity.Sep 6 2018, 15:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 6 2018, 16:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3215: Diff 4793.Sep 6 2018, 16:13
jasonbcox requested changes to this revision.Sep 6 2018, 20:55
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
test/functional/timing.json
7 ↗(On Diff #4793)

This should be a separate diff.

test/functional/wallet-hd.py
116 ↗(On Diff #4793)

Needs a test case for just the start param. ie. rescanblockchain(1)

This revision now requires changes to proceed.Sep 6 2018, 20:55
deadalnix added inline comments.Sep 10 2018, 14:42
test/functional/timing.json
7 ↗(On Diff #4793)

No, regenerating these when adding new intergation tests is definitively required.

A bot doing it automagically would be better, however :)

deadalnix updated this revision to Diff 4839.Sep 10 2018, 14:47

Add missing test cases

teamcity added a comment.Sep 10 2018, 14:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Sep 10 2018, 15:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3247: Diff 4839.Sep 10 2018, 15:24
jasonbcox accepted this revision.Sep 17 2018, 22:25
This revision is now accepted and ready to land.Sep 17 2018, 22:25
Closed by commit rABCfa795ffea08c: [Wallet] Add RPC call "rescanblockchain <startheight> <stopheight>" (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by deadalnix). · Explain WhySep 17 2018, 22:26
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
qt/
test/
2 lines
rpc/
2 lines
wallet/
84 lines
test/
6 lines
1 line
15 lines
test/
functional/
140 lines
32 lines

Diff 4839

View Options

src/qt/test/wallettests.cpp

Loading...
View Options

src/rpc/client.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/wallet_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/timing.json

Loading...
View Options

test/functional/wallet-hd.py

Loading...