Differential D17308

Add NASM as a dependency for the windows build
ClosedPublic
Actions

Authored by Fabien on Fri, Dec 6, 21:12.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCf699f5428392: Add NASM as a dependency for the windows build

Summary

This is part of the fix to build the chronik electrum interface on windows. The other part is an upstream fix for the jsonrpc library.

Test Plan

Run the windows build and check the error is now different. Repeat with guix.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

win_nasm

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31561
Build 62619: Build Diff
Build 62618: arc lint + arc unit

Event Timeline

Fabien created this revision.Fri, Dec 6, 21:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Dec 6, 21:12

Fabien requested review of this revision.Fri, Dec 6, 21:12

Harbormaster completed remote builds in B31561: Diff 51454.Fri, Dec 6, 21:13

PiRK accepted this revision.Sat, Dec 7, 10:46

This revision is now accepted and ready to land.Sat, Dec 7, 10:46

Closed by commit rABCf699f5428392: Add NASM as a dependency for the windows build (authored by Fabien). · Explain WhyMon, Dec 9, 08:30

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCf699f5428392: Add NASM as a dependency for the windows build.

Revision Contents
Changeset List

Path

Size

contrib/

guix/

manifest.scm

6 lines

utils/

install-dependencies-bookworm.sh

1 line

Diff 51454

View Options

contrib/guix/manifest.scm