Page MenuHomePhabricator

Revert "Revert "[Cashtab] Convert wallet context to ts""
ClosedPublic

Authored by bytesofman on Dec 7 2024, 07:25.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCa0b810946010: Revert "Revert "[Cashtab] Convert wallet context to ts""
Summary

This reverts commit b88a433009eaca5a4fcb685f7a611665f115881b.

Identified and resolved the bug that caused this to fail builds in prod. Was an issue with not properly initWasm()

See updated file cashtab/src/index.tsx and the much lighter lint-related changes that are applied here vs in the original diff.

Test Plan

npm test
npm start and app loads
npm run build and app builds

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ts-try-again
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31568
Build 62633: Build Diffcashtab-tests
Build 62632: arc lint + arc unit

Event Timeline

fix the bug that was breaking builds

bytesofman edited the test plan for this revision. (Show Details)
bytesofman edited the summary of this revision. (Show Details)

Tail of the build log:

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-lib@1.1.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

Installing ecash-agora dependencies...
/work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.2.0 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/modules/ecash-agora /work/modules/ecash-lib /work/modules/ecash-lib-wasm /work/modules/ecash-script /work/modules/chronik-client /work/modules/mock-chronik-client /work/modules/ecashaddrjs /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1489 packages, and audited 3335 packages in 26s

323 packages are looking for funding
  run `npm fund` for details

6 vulnerabilities (4 moderate, 2 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> cashtab@3.2.7 build
> node scripts/build.js

Creating an optimized production build...

Treating warnings as errors because process.env.CI = true.
Most CI servers set it automatically.

Failed to compile.

[eslint] 
src/index.tsx
  Line 5:17:  'useEffect' is defined but never used  @typescript-eslint/no-unused-vars


Build cashtab-tests failed with exit code 1
bytesofman published this revision for review.Dec 7 2024, 08:13
This revision is now accepted and ready to land.Dec 7 2024, 23:16