Differential D17387

Fix a race in abc_p2p_avalanche_remote_proofs.py
ClosedPublic
Actions

Authored by Fabien on Mon, Dec 23, 09:56.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC504a0b703be6: Fix a race in abc_p2p_avalanche_remote_proofs.py

Summary

When add_outbound_p2p_connection returns there is no guarantee that the node is available from the RPC yet. This diff waits for the node to account for the new remote to fix this.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_remote_proofs

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mon, Dec 23, 09:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Dec 23, 09:56

Fabien requested review of this revision.Mon, Dec 23, 09:56

Harbormaster completed remote builds in B31742: Diff 51719.Mon, Dec 23, 10:11

bytesofman accepted this revision.Mon, Dec 23, 11:59

This revision is now accepted and ready to land.Mon, Dec 23, 11:59

Closed by commit rABC504a0b703be6: Fix a race in abc_p2p_avalanche_remote_proofs.py (authored by Fabien). · Explain WhyMon, Dec 23, 15:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC504a0b703be6: Fix a race in abc_p2p_avalanche_remote_proofs.py.

Fabien mentioned this in D17392: Wait for remote proof messages in functional tests.Mon, Dec 23, 22:06

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_remote_proofs.py

3 lines

Diff 51726

View Options

test/functional/abc_p2p_avalanche_remote_proofs.py

Fix a race in abc_p2p_avalanche_remote_proofs.pyClosedPublicActions