Differential D17389

init: disallow reindex-chainstate when pruning
ClosedPublic
Actions

Authored by Fabien on Mon, Dec 23, 10:26.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC541bfc8db064: init: disallow reindex-chainstate when pruning

Summary

This fixes a bug where the node would be stuck in an
endless loop when combining these parameters.

Backport of core#24626.

Depends on D17388.

Test Plan

./test/functional/test_runner.py feature_pruning

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR24626

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31744
Build 62982: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 62981: arc lint + arc unit

Event Timeline

Fabien created this revision.Mon, Dec 23, 10:26

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Dec 23, 10:26

Fabien requested review of this revision.Mon, Dec 23, 10:26

teamcity edited the summary of this revision. (Show Details)Mon, Dec 23, 10:26

Harbormaster completed remote builds in B31744: Diff 51721.Mon, Dec 23, 10:47

Fabien added a child revision: D17390: Improve Indices on pruned nodes via prune blockers.Mon, Dec 23, 10:58

PiRK accepted this revision.Mon, Dec 23, 15:42

This revision is now accepted and ready to land.Mon, Dec 23, 15:42

Closed by commit rABC541bfc8db064: init: disallow reindex-chainstate when pruning (authored by Martin Zumsande <mzumsande@gmail.com>, committed by Fabien). · Explain WhyMon, Dec 23, 15:53

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC541bfc8db064: init: disallow reindex-chainstate when pruning.

Revision Contents
Changeset List

Path

Size

src/

init.cpp

6 lines

test/

functional/

feature_pruning.py

4 lines

Diff 51721

View Options

src/init.cpp