Differential D17398
[CI] Improve handling of JS dependencies in build-configurations CI Authored by bytesofman on Thu, Dec 26, 16:03.
Details
The modular use of "DEPENDS_" variables made sense when we were dealing with only 1 or 2 dependencies. Now we have many, and also the order matters. Refactor build-configurations.py to accept yml definitions of dependencies. Organize dependency actions in a specific yml file. CI tests for js-mocha and js-mocha-integration-tests templates Potentially I called the bot wrong (can you call e.g. @bot alias-server-tests mock-chronik-client-tests or do you need to do @bot alias-server-tests @bot mock-chronik-client-tests). Also should make sure this change doesn't impact other builds, not sure on the best approach there
Diff Detail
Event TimelineComment Actions js-mocha tests @bot alias-server-tests ecash-herald-tests token-server-tests mock-chronik-client-tests b58-ts-tests chronik-client-tests ecash-lib-tests ecash-agora-tests ecashaddrjs-tests ecash-script-tests ecash-coinselect-tests Comment Actions js-mocha-integration-tests @bot ecash-agora-integration-tests ecash-lib-integration-tests chronik-client-integration-tests Comment Actions Build Bitcoin ABC Diffs / Diff Testing (alias-server-tests) failed.
Tail of the build log:
> mock-chronik-client@2.1.1 build
> tsc
/work/apps/alias-server /work/modules/mock-chronik-client /work/modules/chronik-client /work/modules/ecash-script /work/modules/ecashaddrjs /work/abc-ci-builds/alias-server-tests
npm warn deprecated har-validator@5.1.5: this library is no longer supported
npm warn deprecated request@2.88.2: request has been deprecated, see https://github.com/request/request/issues/3142
npm warn deprecated uuid@3.4.0: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.
added 612 packages, and audited 616 packages in 6s
94 packages are looking for funding
run `npm fund` for details
15 vulnerabilities (3 low, 7 moderate, 5 high)
To address issues that do not require attention, run:
npm audit fix
To address all issues (including breaking changes), run:
npm audit fix --force
Run `npm audit` for details.
CI not configured to test build.
> alias-server@1.0.0 test
> mocha --reporter mocha-junit-reporter --reporter-options mochaFile=test_results/alias-server-junit.xml --reporter-options testsuitesTitle=Alias Server Unit Tests --reporter-options rootSuiteTitle=Alias Server
Connected successfully to MongoDB server
Error in function updateServerState. MongoServerError: interrupted at shutdown
at Connection.sendCommand (/work/apps/alias-server/node_modules/mongodb/lib/cmap/connection.js:290:27)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Connection.command (/work/apps/alias-server/node_modules/mongodb/lib/cmap/connection.js:317:26)
at async Server.command (/work/apps/alias-server/node_modules/mongodb/lib/sdam/server.js:167:29)
at async UpdateOneOperation.executeCommand (/work/apps/alias-server/node_modules/mongodb/lib/operations/command.js:73:16)
at async UpdateOneOperation.execute (/work/apps/alias-server/node_modules/mongodb/lib/operations/update.js:55:21)
at async UpdateOneOperation.execute (/work/apps/alias-server/node_modules/mongodb/lib/operations/update.js:69:21)
at async tryOperation (/work/apps/alias-server/node_modules/mongodb/lib/operations/execute_operation.js:199:20)
at async executeOperation (/work/apps/alias-server/node_modules/mongodb/lib/operations/execute_operation.js:69:16)
at async Collection.updateOne (/work/apps/alias-server/node_modules/mongodb/lib/collection.js:204:16)
at async Object.updateServerState (/work/apps/alias-server/src/db.js:28:92)
at async initializeDb (/work/apps/alias-server/src/db.js:21:26)
at async Context.<anonymous> (/work/apps/alias-server/test/app.test.js:35:18) {
errorResponse: {
ok: 0,
errmsg: 'interrupted at shutdown',
code: 11600,
codeName: 'InterruptedAtShutdown'
},
ok: 0,
code: 11600,
codeName: 'InterruptedAtShutdown',
[Symbol(errorLabels)]: Set(1) { 'ResetPool' }
}
Initialized serverState on app startup
Configured connection to database ecashAliases
Connected successfully to MongoDB server
Initialized serverState on app startup
Configured connection to database ecashAliases
Build alias-server-tests timed out after 3600.0sComment Actions the timeout failure here does not appear related to this CI patch. running alias-server-tests again in isolation to confirm Comment Actions I like the top level API, but this can be simplified a bit. See suggestions.
Comment Actions Simplifying by removing dependencies.yml and its custom methods, instead creating script steps for the dependencies, parsing these before building Comment Actions Much better logic. I am not totally sure if my implementation here is the right approach (parsing dependencies, making new BuildConfigurations for each one, adding to steps), though I was able to get it to work locally. test here js-mocha tests and js-mocha-integration-tests @bot alias-server-tests ecash-herald-tests token-server-tests mock-chronik-client-tests b58-ts-tests chronik-client-tests ecash-lib-tests ecash-agora-tests ecashaddrjs-tests ecash-script-tests ecash-coinselect-tests ecash-agora-integration-tests ecash-lib-integration-tests chronik-client-integration-tests
| ||||||||||||||||||||||||||||||||||||||