Page MenuHomePhabricator

[alias-server] Remove alias-server from the monorepo
ClosedPublic

Authored by bytesofman on Fri, Dec 27, 00:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC166784aa02b4: [alias-server] Remove alias-server from the monorepo
Summary

alias-server was a custom implementation of an OP_RETURN spec. It was intended to support prod implementation of the alias spec, and Cashtab was modified to work with this spec.

The pace of infra development on eCash has left alias-server obsolete. It would have been a difficult, bug-prone, and maintenance-heavy approach in the best case scenario. This was originally thought justifiable for the value of the feature and the then-seemingly-low likelihood of better options.

Now though we have numerous better options to choose from. With the success of Agora as a chronik plugin, it is clear that attempting to implement any sort of spec with a custom indexer is the wrong approach. Either modify chronik or create a plugin in chronik.

Agora also presents a ready avenue for selling aliases, provided we work out the spec properly. Before this was always a pipe dream "to figure out later."

Removing this repo and confirming it is the wrong approach is a tough call but it needs to be seen as a sunk cost. The cost of maintaining this repo has already been high, despite no prod use. Aliases are an important feature but the cost of getting it wrong to have them now is much higher than the cost of waiting to get it right.

Test Plan

Proofread, confirm CI change

Diff Detail

Repository
rABC Bitcoin ABC
Branch
alias-server-gone
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 31781
Build 63055: Build Diffalias-server-tests
Build 63054: arc lint + arc unit

Event Timeline

The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.

I believe this is expected with this step being removed

This revision is now accepted and ready to land.Fri, Dec 27, 15:33
This revision was landed with ongoing or failed builds.Fri, Dec 27, 17:47
This revision was automatically updated to reflect the committed changes.