Paths

Table of Contentst

Differential D17414

[e.cash] Add XECX to use ecash page
ClosedPublic
Actions

Authored by bytesofman on Dec 28 2024, 00:07.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC569e17ff35c5: [e.cash] Add XECX to use ecash page

Summary

Add new tile to use ecash page

Test Plan

preview or npm run dev, proofread

image.png (460×1 px, 94 KB)

Diff Detail

Repository

rABC Bitcoin ABC

Branch

xecx-landing

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 31799
Build 63091: Build Diff
Build 63090: arc lint + arc unit

Event Timeline

bytesofman created this revision.Dec 28 2024, 00:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 28 2024, 00:07

Harbormaster completed remote builds in B31798: Diff 51793.Dec 28 2024, 00:07

add logo, add second button and flexbox

Harbormaster completed remote builds in B31799: Diff 51794.Dec 28 2024, 04:10

bytesofman edited the test plan for this revision. (Show Details)Dec 28 2024, 04:10

bytesofman published this revision for review.Dec 28 2024, 04:15

Fabien requested changes to this revision.Dec 28 2024, 20:46

Fabien added a subscriber: Fabien.

Fabien added inline comments.

web/e.cash/pages/use-ecash.js
241	This link doesn't work

This revision now requires changes to proceed.Dec 28 2024, 20:46

bytesofman requested review of this revision.Dec 28 2024, 22:01

bytesofman marked an inline comment as done.

bytesofman added inline comments.

web/e.cash/pages/use-ecash.js
241	mb the site was down? works for me with `npm run dev` or popping it into a browser

emack added a subscriber: emack.Dec 29 2024, 00:08

emack added inline comments.

web/e.cash/pages/use-ecash.js
241	FYI works for me

Fabien accepted this revision.Dec 29 2024, 08:50

Fabien added inline comments.

web/e.cash/pages/use-ecash.js
241	mb the site was down? works for me with `npm run dev` or popping it into a browser I think so. A couple minutes after my comment it was up so I thought you restarted it or something.

This revision is now accepted and ready to land.Dec 29 2024, 08:50

Closed by commit rABC569e17ff35c5: [e.cash] Add XECX to use ecash page (authored by bytesofman). · Explain WhyDec 29 2024, 11:54

This revision was automatically updated to reflect the committed changes.

bytesofman marked an inline comment as done.

bytesofman added a commit: rABC569e17ff35c5: [e.cash] Add XECX to use ecash page.

Revision Contents
Changeset List

Path

Size

web/

e.cash/

pages/

32 lines

public/

images/

xecx-logo-white.png

styles/

7 lines

Diff 51794

web/e.cash/pages/use-ecash.js

Loading...

web/e.cash/public/images/xecx-logo-white.png

Loading...

web/e.cash/styles/common.js

Loading...