[Cashtab] Highlight your own offers in agora orderbook
ClosedPublic
Actions

Authored by bytesofman on Thu, Jan 2, 13:46.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCe90d67768707: [Cashtab] Highlight your own offers in agora orderbook

Summary

For OrderBook components with many offers, the user must click through all of the offers to find their own (if they have some). Modify the css so that offers created by the active wallet are highlighted in a still-subdued-but-recognizably-different color (color is similar to the secondary accent color of the cancel button).

Test Plan

npm test, see screenshot

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Thu, Jan 2, 13:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jan 2, 13:46

add to theme

Harbormaster completed remote builds in B31880: Diff 51909.Thu, Jan 2, 13:51

Harbormaster completed remote builds in B31881: Diff 51910.Thu, Jan 2, 13:54

bytesofman published this revision for review.Thu, Jan 2, 13:55

bytesofman edited the test plan for this revision. (Show Details)

I want to propose an alternative approach here: add a X to the right of yours listing that is a shortcut for the cancel action.
This is similar to what is done on most exchanges. It's still fine to highlight if you want to, but might not be necessary

In D17453#396849, @Fabien wrote:

I want to propose an alternative approach here: add a X to the right of yours listing that is a shortcut for the cancel action.
This is similar to what is done on most exchanges. It's still fine to highlight if you want to, but might not be necessary

I think we can do this after -- main reason being, this diff also introduces the functionality of "is this specific offer your offer?" -- and I want to use that functionality to show unaccceptable agora offfers to creators, but not to buyers

the "x" thing would be useful but it does need some more rendering logic -- and this will also apply to the "unacceptable" offers so we should get that feature in first

Fabien accepted this revision.Thu, Jan 2, 14:16

This revision is now accepted and ready to land.Thu, Jan 2, 14:16

bytesofman added a child revision: D17455: [Cashtab] Do not show unacceptable offers to buyers, highlight them uniquely to sellers.Thu, Jan 2, 14:24

Closed by commit rABCe90d67768707: [Cashtab] Highlight your own offers in agora orderbook (authored by bytesofman). · Explain WhyThu, Jan 2, 15:19

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCe90d67768707: [Cashtab] Highlight your own offers in agora orderbook.

bytesofman removed a child revision: D17455: [Cashtab] Do not show unacceptable offers to buyers, highlight them uniquely to sellers.Thu, Jan 2, 15:31