Page MenuHomePhabricator
Differential D17522

[chronik] rename the MerkleTree struct
ClosedPublic
Actions

Authored by PiRK on Mon, Jan 13, 12:18.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC798aa50067a8: [chronik] rename the MerkleTree struct
Summary

This diff renames the struct and makes a few comment more generic because I plan to reuse it transaction ids in addition to block hashes.
No change in behavior.

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Mon, Jan 13, 12:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Jan 13, 12:18
PiRK requested review of this revision.Mon, Jan 13, 12:18
PiRK mentioned this in D17514: [chronik] implement blockchain.transaction.get_merkle Electrum method.Mon, Jan 13, 12:23
PiRK added a child revision: D17514: [chronik] implement blockchain.transaction.get_merkle Electrum method.Mon, Jan 13, 12:25
Harbormaster completed remote builds in B32066: Diff 52160.Mon, Jan 13, 12:42
Fabien requested changes to this revision.Mon, Jan 13, 15:16
Fabien added a subscriber: Fabien.
Fabien added inline comments.
package.json
4 ↗(On Diff #52160)

This moves this in another diff

This revision now requires changes to proceed.Mon, Jan 13, 15:16
PiRK updated this revision to Diff 52167.Mon, Jan 13, 15:41

revert accidental changes to package(-lock).json

tobias_ruck added a subscriber: tobias_ruck.Mon, Jan 13, 15:49

Can you change the title to indicate this is just a rename? It seemed to me as this would generalize behavior somehow (e.g. adding a generic param)

PiRK retitled this revision from [chronik] make the MerkleTree struct more generic to [chronik] rename the MerkleTree struct.Mon, Jan 13, 15:55
Harbormaster completed remote builds in B32070: Diff 52167.Mon, Jan 13, 16:04
Fabien accepted this revision.Mon, Jan 13, 16:40
This revision is now accepted and ready to land.Mon, Jan 13, 16:40
Closed by commit rABC798aa50067a8: [chronik] rename the MerkleTree struct (authored by PiRK). · Explain WhyMon, Jan 13, 19:19
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC798aa50067a8: [chronik] rename the MerkleTree struct.

Revision Contents
Changeset List

PathSize
chronik/
chronik-indexer/
src/
6 lines
38 lines
query/
4 lines

Diff 52172

View Options

chronik/chronik-indexer/src/indexer.rs

Loading...
View Options

chronik/chronik-indexer/src/merkle.rs

Loading...
View Options

chronik/chronik-indexer/src/query/blocks.rs

Loading...