Differential D1753

Enable host lookups for -proxy and -onion parameters
ClosedPublic
Actions

Authored by deadalnix on Sep 10 2018, 15:01.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGd34dc5be7f94: Enable host lookups for -proxy and -onion parameters
rABCd34dc5be7f94: Enable host lookups for -proxy and -onion parameters

Summary

Extends -dns parameter (via fNameLookup) to control these two new parameters in addition to -addnode, -connect, and -seednode

Moves fNameLookup assignment earlier as needed

Changes -proxy and -onion to use Lookup() instead of LookupNumeric()

This is backport of Core PR9774

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 10 2018, 15:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2018, 15:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3248: Diff 4840.Sep 10 2018, 15:41

schancel accepted this revision.Sep 10 2018, 20:55

This revision is now accepted and ready to land.Sep 10 2018, 20:55

Closed by commit rABCd34dc5be7f94: Enable host lookups for -proxy and -onion parameters (authored by Johnathan Corgan <johnathan@corganlabs.com>, committed by deadalnix). · Explain WhySep 10 2018, 21:45

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

30 lines

Diff 4858

src/init.cpp

Loading...