[electrum] Bugfix: close the "Check your trezor" popup after entering a passphrase
ClosedPublic
Actions

Authored by Fabien on Thu, Jan 16, 22:01.

Details

Reviewers

bytesofman
PiRK

Group Reviewers

Restricted Project

Commits

rABC512087c6a1b2: [electrum] Bugfix: close the "Check your trezor" popup after entering a…

Summary

The clear signal that kills the popup is emitted but the flow don't wait for completion, causing a race when another flow is started. This causes the popup to remain on screen and raise an exception upon closure.

Test Plan

Unlock a trezor HW and check the popup is closed as expected.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Thu, Jan 16, 22:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jan 16, 22:01

Fabien requested review of this revision.Thu, Jan 16, 22:01

Harbormaster completed remote builds in B32131: Diff 52252.Thu, Jan 16, 22:03

bytesofman accepted this revision.Fri, Jan 17, 02:39

This revision is now accepted and ready to land.Fri, Jan 17, 02:39

tested with a Trezor T

Closed by commit rABC512087c6a1b2: [electrum] Bugfix: close the "Check your trezor" popup after entering a… (authored by Fabien). · Explain WhyFri, Jan 17, 08:18

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC512087c6a1b2: [electrum] Bugfix: close the "Check your trezor" popup after entering a….

Fabien mentioned this in D17563: [electrum] Fix Trezor 1 unlocking.Sat, Jan 18, 21:57

Fabien mentioned this in rABCedd93d52945b: [electrum] Fix Trezor 1 unlocking.Mon, Jan 20, 08:08

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc_plugins/

hw_wallet/

qt.py

3 lines

Diff 52278

View Options

electrum/electrumabc_plugins/hw_wallet/qt.py

[electrum] Bugfix: close the "Check your trezor" popup after entering a passphraseClosedPublicActions