Differential D1755

Fix make check on darwin
ClosedPublic
Actions

Authored by schancel on Sep 10 2018, 15:44.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING4f834d34a882: Fix make check on darwin
rABC4f834d34a882: Fix make check on darwin

Summary

Disambiguate multiplication between longs and Amounts

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix-build

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3250
Build 4587: Bitcoin ABC Buildbot (legacy)
Build 4586: arc lint + arc unit

Event Timeline

schancel created this revision.Sep 10 2018, 15:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2018, 15:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3250: Diff 4842!Sep 10 2018, 15:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

This is breaking the build on CI.

This revision now requires changes to proceed.Sep 10 2018, 16:30

Change fix strategy

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Sep 10 2018, 17:16

This revision is now accepted and ready to land.Sep 10 2018, 17:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3251: Diff 4844.Sep 10 2018, 17:47

Closed by commit rABC4f834d34a882: Fix make check on darwin (authored by schancel). · Explain WhySep 10 2018, 18:01

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

amount.h

6 lines

Diff 4842

View Options

Fix make check on darwinClosedPublicActions