Page MenuHomePhabricator
Differential D1755

Fix make check on darwin
ClosedPublic
Actions

Authored by schancel on Sep 10 2018, 15:44.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING4f834d34a882: Fix make check on darwin
rABC4f834d34a882: Fix make check on darwin
Summary

Disambiguate multiplication between longs and Amounts

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-build
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3251
Build 4589: Bitcoin ABC Buildbot (legacy)
Build 4588: arc lint + arc unit

Event Timeline

schancel created this revision.Sep 10 2018, 15:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2018, 15:44
teamcity added a subscriber: teamcity.Sep 10 2018, 15:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster failed remote builds in B3250: Diff 4842!Sep 10 2018, 15:45
teamcity added a comment.Sep 10 2018, 15:45

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

deadalnix requested changes to this revision.Sep 10 2018, 16:30
deadalnix added a subscriber: deadalnix.

This is breaking the build on CI.

This revision now requires changes to proceed.Sep 10 2018, 16:30
schancel updated this revision to Diff 4844.Sep 10 2018, 17:08

Change fix strategy

teamcity added a comment.Sep 10 2018, 17:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Sep 10 2018, 17:16
This revision is now accepted and ready to land.Sep 10 2018, 17:16
teamcity added a comment.Sep 10 2018, 17:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3251: Diff 4844.Sep 10 2018, 17:47
Closed by commit rABC4f834d34a882: Fix make check on darwin (authored by schancel). · Explain WhySep 10 2018, 18:01
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
qt/
test/
4 lines
test/
2 lines
8 lines
2 lines

Diff 4844

View Options

src/qt/test/uritests.cpp

Loading...
View Options

src/test/coins_tests.cpp

Loading...
View Options

src/test/rpc_tests.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...