Page MenuHomePhabricator
Differential D17563

[electrum] Fix Trezor 1 unlocking
ClosedPublic
Actions

Authored by Fabien on Sat, Jan 18, 21:57.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCedd93d52945b: [electrum] Fix Trezor 1 unlocking
Summary

2 bugs have been introduced recently that prevent the use of a Trezor 1:

  • D17547 caused the pin window to close the passphrase request prematurely due to some missed legacy code
  • D17555 was checking the device model using an integer instead of a string, preventing the seed entry method to be selected. As a consequence it was impossible to recover a Trezor 1.
Test Plan

Unlock a Trezor 1, wipe it, then recover it from the previous seed.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
electrum_fix_trezor1_unlock
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32160
Build 63810: Build Diffelectrum-tests
Build 63809: arc lint + arc unit

Event Timeline

Fabien created this revision.Sat, Jan 18, 21:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Jan 18, 21:57
Fabien requested review of this revision.Sat, Jan 18, 21:57
Harbormaster completed remote builds in B32160: Diff 52305.Sat, Jan 18, 22:00
PiRK accepted this revision.Sun, Jan 19, 21:17
This revision is now accepted and ready to land.Sun, Jan 19, 21:17
Closed by commit rABCedd93d52945b: [electrum] Fix Trezor 1 unlocking (authored by Fabien). · Explain WhyMon, Jan 20, 08:08
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCedd93d52945b: [electrum] Fix Trezor 1 unlocking.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc_plugins/
trezor/
4 lines

Diff 52305

View Options

electrum/electrumabc_plugins/trezor/qt.py

Loading...