Page MenuHomePhabricator
Differential D17566

[e.cash] Remove eCashPoker
AcceptedPublic
Actions

Authored by Mengerian on Mon, Jan 20, 04:13.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Test Plan

Ran the site locally, check that Use eCash page looks fine and the poker section is gone.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
e.cash-remove-poker
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32163
Build 63816: Build Diff
Build 63815: arc lint + arc unit

Event Timeline

Mengerian created this revision.Mon, Jan 20, 04:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Jan 20, 04:13
Mengerian requested review of this revision.Mon, Jan 20, 04:13
Harbormaster completed remote builds in B32163: Diff 52308.Mon, Jan 20, 04:13
bytesofman requested changes to this revision.Mon, Jan 20, 08:08
bytesofman added a subscriber: bytesofman.
bytesofman added inline comments.
web/e.cash/package-lock.json
544

back out these unrelated package-lock.json changes

easiest way is to just copy paste the "show file on the left" from this diff

This revision now requires changes to proceed.Mon, Jan 20, 08:08
Fabien added a subscriber: Fabien.Mon, Jan 20, 08:09
Fabien added inline comments.
web/e.cash/package-lock.json
544

Why did they appear in the first place ? Running npm install instead of npm ci ?

bytesofman accepted this revision.Mon, Jan 20, 10:58

greening this as I don't want to block it when I go to bed, but the package-lock.json changes should be backed out before landing

This revision is now accepted and ready to land.Mon, Jan 20, 10:58

Revision Contents
Changeset List

PathSize
web/
e.cash/
912 lines
pages/
20 lines
public/
images/

Diff 52308

View Options

web/e.cash/package-lock.json

Loading...
View Options

web/e.cash/pages/use-ecash.js

Loading...
View Options

web/e.cash/public/images/ecash-poker-logo.png

Loading...