Differential D17618

[avalanche] Track the finalized txs total sigchecks
ClosedPublic
Actions

Authored by Fabien on Jan 31 2025, 09:38.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC82cfa296052e: [avalanche] Track the finalized txs total sigchecks

Summary

Similar to their total size added in D17617.

Depends on D17617.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 31 2025, 09:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 31 2025, 09:38

Fabien requested review of this revision.Jan 31 2025, 09:38

Harbormaster completed remote builds in B32270: Diff 52462.Jan 31 2025, 09:46

Build Bitcoin ABC Diffs / Diff Testing (lint-circular-dependencies) failed.

Tail of the build log:

/work /work/abc-ci-builds/lint-circular-dependencies
A new circular dependency in the form of "txmempool -> validation -> txmempool" appears to have been introduced.

A new circular dependency in the form of "policy/block/preconsensus -> txmempool -> validation -> policy/block/preconsensus" appears to have been introduced.

/work/abc-ci-builds/lint-circular-dependencies
Build lint-circular-dependencies failed with exit code 1

Remove unnecessary header

Harbormaster completed remote builds in B32271: Diff 52463.Jan 31 2025, 10:12

PiRK accepted this revision.Jan 31 2025, 14:29

This revision is now accepted and ready to land.Jan 31 2025, 14:29

Closed by commit rABC82cfa296052e: [avalanche] Track the finalized txs total sigchecks (authored by Fabien). · Explain WhyJan 31 2025, 19:00

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC82cfa296052e: [avalanche] Track the finalized txs total sigchecks.

Revision Contents
Changeset List

Path

Size

src/

rpc/

4 lines

9 lines

2 lines

test/

functional/

abc_p2p_avalanche_transaction_voting.py

33 lines

Diff 52474

src/rpc/mempool.cpp

Loading...

src/txmempool.h

Loading...

src/txmempool.cpp

Loading...

test/functional/abc_p2p_avalanche_transaction_voting.py

Loading...