Page MenuHomePhabricator

test: improve robustness of connect_nodes()
ClosedPublic

Authored by Fabien on Tue, Feb 11, 09:20.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCb8637fc6645b: test: improve robustness of connect_nodes()
Summary
The 'connect_nodes' function in the test framework relies
on a stable number of peer connections to verify the new
connection between the nodes is successfully established.
This approach is fragile, as any of the peers involved in
the process can drop, lose, or create a connection at any
step, causing subsequent 'wait_until' checks to stall
indefinitely even when the peers in question are connected
successfully.

This commit improves the situation by using the nodes' subversion
and the connection direction (inbound/outbound) to identify the
exact peer connection and perform the checks exclusively on it.

Backport of core#30118 and core#30252.

Test Plan
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable