Differential D17695

[avalanche] Make payout scripts unique in contenders test
ClosedPublic
Actions

Authored by roqqit on Tue, Feb 25, 04:06.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC80581e12b70b: [avalanche] Make payout scripts unique in contenders test

Summary

We're not testing what we think we're testing when contenders all have the same payout address.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

roqqit created this revision.Tue, Feb 25, 04:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Feb 25, 04:06

roqqit requested review of this revision.Tue, Feb 25, 04:06

Harbormaster completed remote builds in B32473: Diff 52745.Tue, Feb 25, 04:10

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_avalanche_contender_voting.py ======

------- Stdout: -------
2025-02-25T04:09:30.090000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20250225_040831/abc_p2p_avalanche_contender_voting_60
2025-02-25T04:09:30.598000Z TestFramework (ERROR): JSONRPC error
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 149, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 139, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 70, in run_test
    quorum = get_quorum()
             ^^^^^^^^^^^^
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 67, in get_quorum
    return [new_ava_interface(node) for _ in range(0, QUORUM_NODE_COUNT)]
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 67, in <listcomp>
    return [new_ava_interface(node) for _ in range(0, QUORUM_NODE_COUNT)]
            ^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 53, in new_ava_interface
    payoutAddress = node.getnewaddress()
                    ^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/coverage.py", line 46, in __call__
    return_val = self.auth_service_proxy_instance.__call__(*args, **kwargs)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/work/test/functional/test_framework/authproxy.py", line 150, in __call__
    raise JSONRPCException(response["error"], status)
test_framework.authproxy.JSONRPCException: Method not found (-32601)
2025-02-25T04:09:30.649000Z TestFramework (INFO): Stopping nodes
2025-02-25T04:09:30.800000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20250225_040831/abc_p2p_avalanche_contender_voting_60
2025-02-25T04:09:30.800000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20250225_040831/abc_p2p_avalanche_contender_voting_60/test_framework.log
2025-02-25T04:09:30.800000Z TestFramework (ERROR): 
2025-02-25T04:09:30.800000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20250225_040831/abc_p2p_avalanche_contender_voting_60' to consolidate all logs
2025-02-25T04:09:30.800000Z TestFramework (ERROR): 
2025-02-25T04:09:30.800000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-02-25T04:09:30.800000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-02-25T04:09:30.800000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_avalanche_contender_voting.py

roqqit added a child revision: D17696: [avalanche] Make contender test more comprehensive.Tue, Feb 25, 04:16

skip if wallet isn't available

Harbormaster completed remote builds in B32475: Diff 52747.Tue, Feb 25, 04:35

PiRK accepted this revision.Tue, Feb 25, 08:32

This revision is now accepted and ready to land.Tue, Feb 25, 08:32

Closed by commit rABC80581e12b70b: [avalanche] Make payout scripts unique in contenders test (authored by roqqit). · Explain WhyTue, Feb 25, 16:28

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABC80581e12b70b: [avalanche] Make payout scripts unique in contenders test.