Differential D17735

build: remove ENABLE_GLICB_COMPAT from builds
ClosedPublic
Actions

Authored by PiRK on Mar 3 2025, 13:45.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCb1e851853035: build: remove ENABLE_GLICB_COMPAT from builds

Summary

The minimum supported glibc version is now 2.31 and the compat checks were dealing with symbols added in 2.28 and 2.29.

This concludes backport of core#22405, core#22930 and core#25233

Test Plan

guix builds

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32565
Build 64618: Build Diff	build-without-wallet · build-debug · build-clang · lint-circular-dependencies · build-clang-tidy · build-diff
Build 64617: arc lint + arc unit

Event Timeline

PiRK created this revision.Mar 3 2025, 13:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2025, 13:45

teamcity edited the summary of this revision. (Show Details)Mar 3 2025, 13:45

@bot guix-linux

teamcity awarded a token.Mar 3 2025, 13:46

Harbormaster completed remote builds in B32564: Diff 52880.Mar 3 2025, 14:00

squash with core#25233, add also glibc to dependencies.md

my ide messed with the markdown format

@bot guix-linux guix-win guix-osx

teamcity updated a token.Mar 3 2025, 14:08

Harbormaster completed remote builds in B32565: Diff 52881.Mar 3 2025, 14:17

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Failed tests logs:

====== Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_contender_voting.py ======

------- Stdout: -------
2025-03-03T14:15:18.408000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20250303_141406/abc_p2p_avalanche_contender_voting_60
2025-03-03T14:15:28.047000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 149, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 139, in _run_test_internal
    self.run_test()
  File "/work/test/functional/abc_p2p_avalanche_contender_voting.py", line 215, in run_test
    assert local_winner_cid in polled_contenders
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError
2025-03-03T14:15:28.098000Z TestFramework (INFO): Stopping nodes
2025-03-03T14:15:28.299000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20250303_141406/abc_p2p_avalanche_contender_voting_60
2025-03-03T14:15:28.299000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20250303_141406/abc_p2p_avalanche_contender_voting_60/test_framework.log
2025-03-03T14:15:28.299000Z TestFramework (ERROR): 
2025-03-03T14:15:28.300000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-diff/test/tmp/test_runner_₿₵_🏃_20250303_141406/abc_p2p_avalanche_contender_voting_60' to consolidate all logs
2025-03-03T14:15:28.300000Z TestFramework (ERROR): 
2025-03-03T14:15:28.300000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-03-03T14:15:28.300000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-03-03T14:15:28.300000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests with the next upgrade activated: abc_p2p_avalanche_contender_voting.py

Harbormaster completed remote builds in B32566: Diff 52882.Mar 3 2025, 14:19

PiRK mentioned this in D17723: [kernel 2c/n] Introduce kernel::Context, encapsulate global init/teardown.Mar 3 2025, 14:19

Fabien accepted this revision.Mar 3 2025, 15:23

This revision is now accepted and ready to land.Mar 3 2025, 15:23

Closed by commit rABCb1e851853035: build: remove ENABLE_GLICB_COMPAT from builds (authored by PiRK). · Explain WhyMar 3 2025, 16:11

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCb1e851853035: build: remove ENABLE_GLICB_COMPAT from builds.