[avalanche] Add the finalized transactions ancestors to the list of recently finalized items
Needs ReviewPublic
Actions

Authored by Fabien on Tue, Mar 4, 10:50.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

So we don't keep polling for ancestors when the child tx has been finalized.

Test Plan

ninja all check-all

Repository

rABC Bitcoin ABC

Branch

avalanche_add_tx_ancestors_to_recently_finalized

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32589
Build 64666: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 64665: arc lint + arc unit

Fabien requested review of this revision.Tue, Mar 4, 10:50

PiRK added inline comments.

src/txmempool.cpp
534	I find this behavior a bit surprising. Shouldn't it be the caller's responsibility to provide an empty output vector? In the current state of the code the vector is always passed empty anyway.
test/functional/abc_p2p_avalanche_transaction_finalization.py
62