Differential D17751

[avalanche] Add the finalized transactions ancestors to the list of recently finalized items
AcceptedPublic
Actions

Authored by Fabien on Tue, Mar 4, 10:50.

Tags

None

Subscribers

Details

Reviewers

PiRK
roqqit

Group Reviewers

Restricted Project

Summary

So we don't keep polling for ancestors when the child tx has been finalized.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_add_tx_ancestors_to_recently_finalized

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32589
Build 64666: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 64665: arc lint + arc unit

Event Timeline

Fabien created this revision.Tue, Mar 4, 10:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Mar 4, 10:50

Fabien requested review of this revision.Tue, Mar 4, 10:50

Harbormaster completed remote builds in B32589: Diff 52918.Tue, Mar 4, 11:31

PiRK added a subscriber: PiRK.Tue, Mar 4, 13:21

PiRK added inline comments.

src/txmempool.cpp
534	I find this behavior a bit surprising. Shouldn't it be the caller's responsibility to provide an empty output vector? In the current state of the code the vector is always passed empty anyway.
test/functional/abc_p2p_avalanche_transaction_finalization.py
62

PiRK accepted this revision.Tue, Mar 4, 14:30

This revision is now accepted and ready to land.Tue, Mar 4, 14:30

Fabien added inline comments.Tue, Mar 4, 15:03

src/txmempool.cpp
534	you want to return the vector if finalized ids, so you need to clear it to fulfill this expectation

Feedback

Harbormaster completed remote builds in B32590: Diff 52926.Tue, Mar 4, 15:18

roqqit accepted this revision.Tue, Mar 4, 16:55

Revision Contents
Changeset List

Path

Size

src/

avalanche/

2 lines

4 lines

net_processing.cpp

9 lines

test/

mempool_tests.cpp

5 lines

4 lines

8 lines

test/

functional/

abc_p2p_avalanche_transaction_finalization.py

59 lines

Diff 52918

src/avalanche/processor.h

Loading...

src/avalanche/processor.cpp

Loading...

src/net_processing.cpp

Loading...

src/test/mempool_tests.cpp

Loading...

src/txmempool.h

Loading...

src/txmempool.cpp

Loading...

test/functional/abc_p2p_avalanche_transaction_finalization.py

Loading...