Page MenuHomePhabricator
Differential D17752

[ecash-coinselect, token-server] Remove ecash-coinselect from the monorepo
ClosedPublic
Actions

Authored by bytesofman on Tue, Mar 4, 18:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC141718de4455: [ecash-coinselect, token-server] Remove ecash-coinselect from the monorepo
Summary

Should have been done when it was deprecated from token-server. Looks like it is still in the token-server package-lock.json as an artifact. Clean up. Remove.

The logic from ecash-coinselect is obsolete and does not work with ecash-lib. Will be implemented in upcoming wallet lib.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
no-more-coinselect
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32592
Build 64672: Build Diffecash-coinselect-tests · token-server-tests
Build 64671: arc lint + arc unit

Event Timeline

bytesofman created this revision.Tue, Mar 4, 18:54
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Mar 4, 18:54
Harbormaster completed remote builds in B32592: Diff 52928.Tue, Mar 4, 18:55
teamcity added a comment.Tue, Mar 4, 18:55
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman published this revision for review.Tue, Mar 4, 21:57

CI failure expected with the lib removed.

token-server tests and builds pass locally

Fabien accepted this revision.Tue, Mar 4, 22:23
This revision is now accepted and ready to land.Tue, Mar 4, 22:23
This revision was landed with ongoing or failed builds.Wed, Mar 5, 16:53
Closed by commit rABC141718de4455: [ecash-coinselect, token-server] Remove ecash-coinselect from the monorepo (authored by bytesofman). · Explain Why
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC141718de4455: [ecash-coinselect, token-server] Remove ecash-coinselect from the monorepo.

Revision Contents
Changeset List

Diff 52928

View Options

apps/token-server/package-lock.json

Loading...
View Options

contrib/teamcity/build-configurations.yml

Loading...
View Options

modules/ecash-coinselect/.dockerignore

Loading...
View Options

modules/ecash-coinselect/.eslintrc.js

Loading...
View Options

modules/ecash-coinselect/.gitignore

Loading...
View Options

modules/ecash-coinselect/.mocharc.js

Loading...
View Options

modules/ecash-coinselect/Dockerfile

Loading...
View Options

modules/ecash-coinselect/LICENSE

Loading...
View Options

modules/ecash-coinselect/README.md

Loading...
View Options

modules/ecash-coinselect/index.d.ts

Loading...
View Options

modules/ecash-coinselect/index.js

Loading...
View Options

modules/ecash-coinselect/mocks/mockChronikUtxos.js

Loading...
View Options

modules/ecash-coinselect/package-lock.json

Loading...
View Options

modules/ecash-coinselect/package.json

Loading...
View Options

modules/ecash-coinselect/src/byteCount.js

Loading...
View Options

modules/ecash-coinselect/src/coinSelect.js

Loading...
View Options

modules/ecash-coinselect/src/utils.js

Loading...
View Options

modules/ecash-coinselect/test/byteCount.test.js

Loading...
View Options

modules/ecash-coinselect/test/coinSelect.test.js

Loading...
View Options

modules/ecash-coinselect/test/utils.test.js

Loading...