Page MenuHomePhabricator
Differential D17782

[ecash-lib] Allow use of .only in mocha test files
Needs RevisionPublic
Actions

Authored by bytesofman on Tue, Mar 11, 22:58.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Summary

Real pain to keep deleting and re-adding this when working on the repo. Now that we are using eslint flat config, arc lint will catch any lingering .only use

Test Plan

Add .only to a test file in ecash-lib, run arc lint, get a lint error, remove it, all good, npm test with a test using .only and only that test runs

Diff Detail

Event Timeline

bytesofman created this revision.Tue, Mar 11, 22:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Mar 11, 22:58
bytesofman published this revision for review.Tue, Mar 11, 23:11
Harbormaster completed remote builds in B32673: Diff 53034.Tue, Mar 11, 23:15
emack requested changes to this revision.Wed, Mar 12, 04:04
emack added a subscriber: emack.

Add .only to a test file in ecash-lib, run arc lint, get a lint error, remove it, all good, npm test with a test using .only and only that test runs

I added .only to describe('SLP Integration Test') and it is not the only test that is run.

image.png (840×692 px, 96 KB)

This revision now requires changes to proceed.Wed, Mar 12, 04:04

Revision Contents
Changeset List

PathSize
modules/
ecash-lib/
4 lines

Diff 53034

View Options

modules/ecash-lib/package.json

Loading...