Fix bench/bench_bitcoin (Select REGTEST Params before wallet init)
ClosedPublic
Actions

Authored by jtoomim on Sep 17 2018, 07:57.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING59d52b9da186: Fix bench/bench_bitcoin (Select REGTEST Params before wallet init)
rABC59d52b9da186: Fix bench/bench_bitcoin (Select REGTEST Params before wallet init)

Summary

globalChainParams needs to be created by SelectParams before it can be used in bench/coin_selection.cpp

Test Plan

bench_bitcoin doesn't crash any longer

Diff Detail

Repository

rABC Bitcoin ABC

Branch

benchfix

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3315
Build 4713: Bitcoin ABC Buildbot (legacy)
Build 4712: arc lint + arc unit

Event Timeline

jtoomim created this revision.Sep 17 2018, 07:57

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 17 2018, 07:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Sep 17 2018, 07:58

This revision is now accepted and ready to land.Sep 17 2018, 07:58

Closed by commit rABC59d52b9da186: Fix bench/bench_bitcoin (Select REGTEST Params before wallet init) (authored by jtoomim). · Explain WhySep 17 2018, 07:59

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B3315: Diff 4946.Sep 17 2018, 08:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

movrcx mentioned this in D1370: Update NSIS installation directory, regkey, icons and imagery from Bitcoin Core to Bitcoin ABC.Sep 17 2018, 18:22

Revision Contents
Changeset List

Path

Size

src/

bench/

coin_selection.cpp

1 line

Diff 4946

View Options

src/bench/coin_selection.cpp

Fix bench/bench_bitcoin (Select REGTEST Params before wallet init)ClosedPublicActions