Paths

Table of Contentst

Differential D17927

rpc: Improve importdescriptor RPC error messages
ClosedPublic
Actions

Authored by PiRK on Sat, Apr 12, 08:01.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC0131c1a63c9e: rpc: Improve importdescriptor RPC error messages

Summary

Particularly add more details in the case of pruning or assumeutxo.

This is a partial backport of core#30909
https://github.com/bitcoin/bitcoin/pull/30909/commits/d73ae603d44f93e4d6c5116f235dd11a0bdbf89c

see D10159 for GetRescanErrorMessage and why this affects a wallet test that imports keys

Depends on D17926

Test Plan

ninja all check-all

Also covered by another test in wallet_assumeutxo.py on my dev branch

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Sat, Apr 12, 08:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, Apr 12, 08:01

PiRK requested review of this revision.Sat, Apr 12, 08:01

teamcity edited the summary of this revision. (Show Details)Sat, Apr 12, 08:01

Harbormaster completed remote builds in B32952: Diff 53462.Sat, Apr 12, 08:16

Fabien accepted this revision.Mon, Apr 14, 09:01

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/wallet/rpc/backup.cpp
1697 ↗	(On Diff #53462)	layout
1707 ↗	(On Diff #53462)	Since you're always adding something to the initial message, you'd rather move the space following the dot in the initial message as well and avoid repeating it 3 times

This revision is now accepted and ready to land.Mon, Apr 14, 09:01

strinrg layouts

Harbormaster completed remote builds in B32955: Diff 53466.Mon, Apr 14, 10:37

Closed by commit rABC0131c1a63c9e: rpc: Improve importdescriptor RPC error messages (authored by PiRK). · Explain WhyMon, Apr 14, 10:58

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC0131c1a63c9e: rpc: Improve importdescriptor RPC error messages.

Revision Contents
Changeset List

Path

Size

src/

wallet/

rpc/

52 lines

test/

wallet_tests.cpp

8 lines

Diff 53472

src/wallet/rpc/backup.cpp

Loading...

src/wallet/test/wallet_tests.cpp

Loading...