test: make MiniWallet produce deterministic transactions
ClosedPublic
Actions

Authored by PiRK on Tue, Apr 15, 06:54.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC03f1074ec32e: test: make MiniWallet produce deterministic transactions

Summary

MiniWallet is used in the assumeutxo functional test to produce transactions for the utxo snapshot, it needs to reliably produce the same txid for the same set of inputs and outputs.
The source of non-determinism is pad_tx, so add an option to this function to use deterministic data to pad the transaction.

Depends on D17932

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32963
Build 65410: Build Diff	build-without-wallet · build-clang-tidy · build-clang · build-diff · build-debug
Build 65409: arc lint + arc unit

Event Timeline

PiRK created this revision.Tue, Apr 15, 06:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Apr 15, 06:54

PiRK requested review of this revision.Tue, Apr 15, 06:54

PiRK added a child revision: D17934: add loadtxoutset & getchainstates RPCs, add functional tests.Tue, Apr 15, 07:02

Harbormaster completed remote builds in B32963: Diff 53480.Tue, Apr 15, 07:05

PiRK added a child revision: D17931: add loadtxoutset & getchainstates RPCs, add functional tests.Tue, Apr 15, 07:05

Please run the extended test suite. If done, update the test plan accordingly

This revision now requires changes to proceed.Tue, Apr 15, 09:46

add extended tests to plan

Harbormaster completed remote builds in B32975: Diff 53496.Tue, Apr 15, 15:19

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[0m[0;32mwallet_txn_clone.py --mineblock            | ✓ Passed  | 3 s
[0m[0;32mwallet_txn_doublespend.py                  | ✓ Passed  | 2 s
[0m[0;32mwallet_txn_doublespend.py --mineblock      | ✓ Passed  | 2 s
[0m[0;32mwallet_watchonly.py                        | ✓ Passed  | 1 s
[0m[0;32mwallet_watchonly.py --usecli               | ✓ Passed  | 1 s
[0m[1;30mchronik_avalanche.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_block.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_block_header.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_block_info.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_block_txs.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_blockchain_info.py                 | ○ Skipped | 0 s
[0m[1;30mchronik_blocks.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_chronik_info.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_cors.py                            | ○ Skipped | 0 s
[0m[1;30mchronik_disable_token_index.py             | ○ Skipped | 0 s
[0m[1;30mchronik_disallow_prune.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_electrum_basic.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_electrum_blockchain.py             | ○ Skipped | 0 s
[0m[1;30mchronik_lokad_id_group.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_mempool_conflicts.py               | ○ Skipped | 0 s
[0m[1;30mchronik_mempool_disconnectpool.py          | ○ Skipped | 0 s
[0m[1;30mchronik_pause.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_plugin_groups.py                   | ○ Skipped | 0 s
[0m[1;30mchronik_plugins.py                         | ○ Skipped | 0 s
[0m[1;30mchronik_plugins_setup.py                   | ○ Skipped | 0 s
[0m[1;30mchronik_raw_tx.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_resync.py                          | ○ Skipped | 0 s
[0m[1;30mchronik_script_confirmed_txs.py            | ○ Skipped | 0 s
[0m[1;30mchronik_script_history.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_script_unconfirmed_txs.py          | ○ Skipped | 0 s
[0m[1;30mchronik_script_utxos.py                    | ○ Skipped | 0 s
[0m[1;30mchronik_scripthash.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_serve.py                           | ○ Skipped | 0 s
[0m[1;30mchronik_spent_by.py                        | ○ Skipped | 0 s
[0m[1;30mchronik_token_alp.py                       | ○ Skipped | 0 s
[0m[1;30mchronik_token_broadcast_txs.py             | ○ Skipped | 0 s
[0m[1;30mchronik_token_burn.py                      | ○ Skipped | 0 s
[0m[1;30mchronik_token_id_group.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_token_parse_failure.py             | ○ Skipped | 0 s
[0m[1;30mchronik_token_script_group.py              | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_fungible.py              | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_mint_vault.py            | ○ Skipped | 0 s
[0m[1;30mchronik_token_slp_nft1.py                  | ○ Skipped | 0 s
[0m[1;30mchronik_tx.py                              | ○ Skipped | 0 s
[0m[1;30mchronik_tx_removal_order.py                | ○ Skipped | 0 s
[0m[1;30mchronik_ws.py                              | ○ Skipped | 0 s
[0m[1;30mchronik_ws_ordering.py                     | ○ Skipped | 0 s
[0m[1;30mchronik_ws_ping.py                         | ○ Skipped | 0 s
[0m[1;30mchronik_ws_script.py                       | ○ Skipped | 0 s
[0m[1;30mfeature_bind_port_discover.py              | ○ Skipped | 0 s
[0m[1;30mfeature_bind_port_externalip.py            | ○ Skipped | 0 s
[0m[1;30minterface_usdt_net.py                      | ○ Skipped | 0 s
[0m[1;30minterface_usdt_utxocache.py                | ○ Skipped | 0 s
[0m[1;30minterface_usdt_validation.py               | ○ Skipped | 0 s
[0m[1m
ALL                                        | ✓ Passed  | 1338 s (accumulated) 
[0mRuntime: 112 s

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

Fabien accepted this revision.Tue, Apr 15, 20:28

This revision is now accepted and ready to land.Tue, Apr 15, 20:28

Closed by commit rABC03f1074ec32e: test: make MiniWallet produce deterministic transactions (authored by PiRK). · Explain WhyWed, Apr 16, 10:32

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC03f1074ec32e: test: make MiniWallet produce deterministic transactions.

PiRK mentioned this in D17939: test: fix generation of conflicting transactions in chronik_electrum_blockchain.py.Wed, Apr 16, 11:37

PiRK mentioned this in rABC087505795565: test: fix generation of conflicting transactions in chronik_electrum_blockchain..Wed, Apr 16, 13:13