Differential D17937

[avalanche] Tests: Move assert_response to avatools
ClosedPublic
Actions

Authored by Fabien on Tue, Apr 15, 13:07.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCc8ee02ff9aa3: [avalanche] Tests: Move assert_response to avatools

Summary

This code is duplicated in several tests for no reason.

Test Plan

ninja check-functional-extended

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_assert_response

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32971
Build 65426: Build Diff	build-diff · build-clang-tidy · build-debug · build-clang · build-without-wallet
Build 65425: arc lint + arc unit

Event Timeline

Fabien created this revision.Tue, Apr 15, 13:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Apr 15, 13:07

Fabien requested review of this revision.Tue, Apr 15, 13:07

Harbormaster completed remote builds in B32971: Diff 53491.Tue, Apr 15, 13:16

PiRK accepted this revision.Tue, Apr 15, 15:39

This revision is now accepted and ready to land.Tue, Apr 15, 15:39

Closed by commit rABCc8ee02ff9aa3: [avalanche] Tests: Move assert_response to avatools (authored by Fabien). · Explain WhyWed, Apr 16, 09:11

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc8ee02ff9aa3: [avalanche] Tests: Move assert_response to avatools.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_contender_voting.py

65 lines

abc_p2p_avalanche_policy_minerfund.py

30 lines

abc_p2p_avalanche_policy_rtt.py

28 lines

abc_p2p_avalanche_policy_stakingrewards.py

30 lines

abc_p2p_avalanche_transaction_voting.py

57 lines

abc_p2p_avalanche_voting.py

47 lines

abc_rpc_invalidateavalancheproof.py

24 lines

test_framework/

avatools.py

20 lines

Diff 53491

View Options

test/functional/abc_p2p_avalanche_contender_voting.py

View Options

test/functional/abc_p2p_avalanche_policy_minerfund.py

View Options

test/functional/abc_p2p_avalanche_policy_rtt.py

View Options

test/functional/abc_p2p_avalanche_policy_stakingrewards.py

View Options

test/functional/abc_p2p_avalanche_transaction_voting.py

View Options

test/functional/abc_p2p_avalanche_voting.py

View Options

test/functional/abc_rpc_invalidateavalancheproof.py

View Options

test/functional/test_framework/avatools.py

[avalanche] Tests: Move assert_response to avatoolsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 53491

test/functional/abc_p2p_avalanche_contender_voting.py

test/functional/abc_p2p_avalanche_policy_minerfund.py

test/functional/abc_p2p_avalanche_policy_rtt.py

test/functional/abc_p2p_avalanche_policy_stakingrewards.py

test/functional/abc_p2p_avalanche_transaction_voting.py

test/functional/abc_p2p_avalanche_voting.py

test/functional/abc_rpc_invalidateavalancheproof.py

test/functional/test_framework/avatools.py

[avalanche] Tests: Move assert_response to avatools
ClosedPublic
Actions

Revision Contents
Changeset List