Differential D18010

[avalanche] Rename isRemoteProof to hasRemoteProofStatus
ClosedPublic
Actions

Authored by roqqit on Mon, Apr 28, 22:23.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC58a4750550e8: [avalanche] Rename isRemoteProof to hasRemoteProofStatus

Summary

isRemoteProof is a misnomer because it does not check the remote status. This confusion led to incorrect usage in contenders which will be fixed in a near future diff.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

roqqit created this revision.Mon, Apr 28, 22:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Apr 28, 22:23

roqqit requested review of this revision.Mon, Apr 28, 22:23

Harbormaster completed remote builds in B33140: Diff 53736.Mon, Apr 28, 22:43

roqqit added a child revision: D18011: [avalanche] Correctly check if a contender is associated with a remote proof.Mon, Apr 28, 23:18

Fabien accepted this revision.Tue, Apr 29, 07:16

This revision is now accepted and ready to land.Tue, Apr 29, 07:16

Closed by commit rABC58a4750550e8: [avalanche] Rename isRemoteProof to hasRemoteProofStatus (authored by roqqit). · Explain WhyTue, Apr 29, 16:42

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABC58a4750550e8: [avalanche] Rename isRemoteProof to hasRemoteProofStatus.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

peermanager.h

2 lines

peermanager.cpp

6 lines

test/

peermanager_tests.cpp

2 lines

Diff 53762

View Options

src/avalanche/peermanager.h

View Options

src/avalanche/peermanager.cpp

View Options

src/avalanche/test/peermanager_tests.cpp

[avalanche] Rename isRemoteProof to hasRemoteProofStatusClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 53762

src/avalanche/peermanager.h

src/avalanche/peermanager.cpp

src/avalanche/test/peermanager_tests.cpp

[avalanche] Rename isRemoteProof to hasRemoteProofStatus
ClosedPublic
Actions

Revision Contents
Changeset List