Page MenuHomePhabricator

p2p: Ignore version msgs after initial version msg
ClosedPublic

Authored by PiRK on Tue, Apr 29, 15:46.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC2a5e0b3fff3d: p2p: Ignore version msgs after initial version msg
Summary

Sending a version message after the intial version message is peer
misbehavior. Though, it seems arbitrary and confusing to disconnect only
after exactly 100 version messages. Duplicate version messages affect us
no different than any other unknown message. So remove the Misbehaving
and ignore the redundant msgs.

This is a partial backport of core#20079
https://github.com/bitcoin/bitcoin/pull/20079/commits/faaad1bbac46cfeb22654b4c59f0aac7a680c03a

Depends on D18017

Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable