Page MenuHomePhabricator
Differential D18023

Fix abc_p2p_avalanche_voting test
ClosedPublic
Actions

Authored by Fabien on Wed, Apr 30, 07:39.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC86b913138c7d: Fix abc_p2p_avalanche_voting test
Summary

D18019 introduced a change in the logging behavior that caused the test to fail. This diff re-introduce some logging for repeated avaresponse failures and update the test accordingly.

Test Plan
./test/functional/test_runner.py abc_p2p_avalanche_voting

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_abc_p2p_avalanche_voting
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33168
Build 65819: Build Diffbuild-debug · build-clang-tidy · build-without-wallet · build-diff · lint-circular-dependencies · build-clang
Build 65818: arc lint + arc unit

Event Timeline

Fabien created this revision.Wed, Apr 30, 07:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 30, 07:39
Fabien requested review of this revision.Wed, Apr 30, 07:39
PiRK accepted this revision.Wed, Apr 30, 07:40
This revision is now accepted and ready to land.Wed, Apr 30, 07:40
Harbormaster completed remote builds in B33168: Diff 53779.Wed, Apr 30, 07:51
Closed by commit rABC86b913138c7d: Fix abc_p2p_avalanche_voting test (authored by Fabien). · Explain WhyWed, Apr 30, 08:20
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC86b913138c7d: Fix abc_p2p_avalanche_voting test.

Revision Contents
Changeset List

PathSize
src/
4 lines
test/
functional/
8 lines

Diff 53779

View Options

src/net_processing.cpp

Loading...
View Options

test/functional/abc_p2p_avalanche_voting.py

Loading...