Differential D18033

[test] Assert the exact list of contenders to be polled in abc_p2p_avalanche_contender_voting
ClosedPublic
Actions

Authored by Fabien on Wed, Apr 30, 16:47.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC19fd8b8c6ea2: [test] Assert the exact list of contenders to be polled in…

Summary

This is more accurate than checking for the number of polls. This also makes the test capable of handling slowly connecting peers, which could cause a contender poll to finalize before the other contenders are registered (so the poll count will be lower than the expected 12). By checking the set over the whole quorum we remove this constraint entirely.

Depends on D18040.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_contender_voting

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_contenders_3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33191
Build 65865: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 65864: arc lint + arc unit

Event Timeline

Fabien created this revision.Wed, Apr 30, 16:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 30, 16:47

Harbormaster completed remote builds in B33178: Diff 53792.Wed, Apr 30, 17:05

Rebase, vote UNKNOWN for non contenders in vote_all_contenders

Fabien added a child revision: D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active.Wed, Apr 30, 20:01

Fabien edited the summary of this revision. (Show Details)Wed, Apr 30, 20:05

Fabien removed a parent revision: D18028: Properly check the node polls for contenders upon restart with no prior block being mined.

Harbormaster completed remote builds in B33185: Diff 53805.Wed, Apr 30, 20:21

Rebase

Fabien published this revision for review.Thu, May 1, 12:14

Fabien retitled this revision from Assert the exact list of contenders to be polled in tests to [test] Assert the exact list of contenders to be polled in abc_p2p_avalanche_contender_voting.

Fabien edited the summary of this revision. (Show Details)

Fabien added a parent revision: D18040: [test] Only activate the quorum after all the peers are connected.

Harbormaster completed remote builds in B33191: Diff 53811.Thu, May 1, 12:25

roqqit accepted this revision.Thu, May 1, 16:03

This revision is now accepted and ready to land.Thu, May 1, 16:03

Closed by commit rABC19fd8b8c6ea2: [test] Assert the exact list of contenders to be polled in… (authored by Fabien). · Explain WhyThu, May 1, 16:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC19fd8b8c6ea2: [test] Assert the exact list of contenders to be polled in….