net_processing: remove Misbehavior score and increments
Needs ReviewPublic
Actions

Authored by PiRK on Wed, Apr 30, 16:58.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

This is now all unused.
Make MaybePunishNodeFor{Block,Tx} return void

This concludes backport of core#29575
https://github.com/bitcoin/bitcoin/pull/29575/commits/ae60d485da33f238ed2186799da4e109d4edd3a1
https://github.com/bitcoin/bitcoin/pull/29575/commits/6eecba475efd025eb011400af58621ad5823994e

Depends on D18032

Test Plan

ninja all check-all-extended

run an ibd with -assumevalid=0 -checkpoints=0

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33180
Build 65843: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 65842: arc lint + arc unit

Event Timeline

PiRK created this revision.Wed, Apr 30, 16:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 30, 16:58

PiRK requested review of this revision.Wed, Apr 30, 16:58

teamcity edited the summary of this revision. (Show Details)Wed, Apr 30, 16:58

rebase so I can arc patch on the server

Harbormaster completed remote builds in B33179: Diff 53793.Wed, Apr 30, 17:10

Harbormaster completed remote builds in B33180: Diff 53797.Wed, Apr 30, 17:13

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: p2p_timeouts.py ======

------- Stdout: -------
2025-04-30T17:12:45.425000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20250430_171120_49753/p2p_timeouts_259
2025-04-30T17:12:47.847000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 152, in main
    self._run_test_internal()
  File "/work/test/functional/test_framework/test_framework.py", line 142, in _run_test_internal
    self.run_test()
  File "/work/test/functional/p2p_timeouts.py", line 85, in run_test
    with self.nodes[0].assert_debug_log(expected_msgs=expected_timeout_logs):
  File "/usr/lib/python3.11/contextlib.py", line 144, in __exit__
    next(self.gen)
  File "/work/test/functional/test_framework/test_node.py", line 647, in assert_debug_log
    self._raise_assertion_error(
  File "/work/test/functional/test_framework/test_node.py", line 271, in _raise_assertion_error
    raise AssertionError(self._node_msg(msg))
AssertionError: [node 0] Captured debug log:

 - 2025-04-30T17:12:45.835176Z (mocktime: 2025-04-30T17:12:47Z) [/work/src/httpserver.cpp:334] [http_request_cb] [http] Received a POST request for / from 127.0.0.1:47708
 - 2025-04-30T17:12:45.835232Z (mocktime: 2025-04-30T17:12:47Z) [/work/src/rpc/request.cpp:188] [parse] [rpc] ThreadRPCServer method=setmocktime user=__cookie__
 - 2025-04-30T17:12:45.835277Z (mocktime: 2025-04-30T17:12:52Z) [/work/src/net.cpp:1545] [InactivityCheck] [net] socket no message in first 3 seconds, 1 0 peer=1
 - 2025-04-30T17:12:45.835334Z (mocktime: 2025-04-30T17:12:52Z) [/work/src/net.cpp:1545] [InactivityCheck] [net] socket no message in first 3 seconds, 0 0 peer=2
 - 2025-04-30T17:12:45.835348Z (mocktime: 2025-04-30T17:12:52Z) [/work/src/net.cpp:573] [CloseSocketDisconnect] [net] disconnecting peer=1
 - 2025-04-30T17:12:45.835380Z (mocktime: 2025-04-30T17:12:52Z) [/work/src/net.cpp:573] [CloseSocketDisconnect] [net] disconnecting peer=2
 - 2025-04-30T17:12:45.835398Z (mocktime: 2025-04-30T17:12:52Z) [/work/src/net_processing.cpp:2538] [FinalizeNode] [net] Cleared nodestate for peer=1
 - 2025-04-30T17:12:45.835408Z (mocktime: 2025-04-30T17:12:52Z) [/work/src/net_processing.cpp:2538] [FinalizeNode] [net] Cleared nodestate for peer=2
 - 2025-04-30T17:12:45.885512Z (mocktime: 2025-04-30T17:12:52Z) [/work/src/net.cpp:1565] [InactivityCheck] [net] version handshake timeout peer=0
 - 2025-04-30T17:12:45.885525Z (mocktime: 2025-04-30T17:12:52Z) [/work/src/net.cpp:573] [CloseSocketDisconnect] [net] disconnecting peer=0
 - 2025-04-30T17:12:45.885582Z (mocktime: 2025-04-30T17:12:52Z) [/work/src/net_processing.cpp:2538] [FinalizeNode] [net] Cleared nodestate for peer=0

Expected messages "['version handshake timeout peer=0',
 'socket no message in first 3 seconds, 1 0 peer=1',
 'Misbehaving: peer=1: non-version message before version handshake',
 'socket no message in first 3 seconds, 0 0 peer=2']" does not partially match the above log.

Missing messages: "['Misbehaving: peer=1: non-version message before version handshake']"

2025-04-30T17:12:47.902000Z TestFramework (INFO): Stopping nodes
2025-04-30T17:12:48.005000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20250430_171120_49753/p2p_timeouts_259
2025-04-30T17:12:48.005000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20250430_171120_49753/p2p_timeouts_259/test_framework.log
2025-04-30T17:12:48.005000Z TestFramework (ERROR): 
2025-04-30T17:12:48.006000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_🏃_20250430_171120_49753/p2p_timeouts_259' to consolidate all logs
2025-04-30T17:12:48.006000Z TestFramework (ERROR): 
2025-04-30T17:12:48.006000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2025-04-30T17:12:48.006000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2025-04-30T17:12:48.006000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: p2p_timeouts.py