[Cashtab] Allow user to receive specified amount of XEC or FIRMA on Receive page
Needs ReviewPublic
Actions

Authored by bytesofman on Wed, May 7, 14:00.

Details

Reviewers

Fabien
emack

Group Reviewers

Restricted Project

Summary

Cashtab send screen supports bip21 query strings. We should allow users to make their own to support point of sale use case.

This is a first pass, where we support custom XEC or FIRMA amounts.

It can be extended to support arbitary token quantities or other bip21.

new receive screen:

Test Plan

npm test

deployed live at test site, check at https://cashtab-local-dev.netlify.app/#/receive

Diff Detail

Repository

rABC Bitcoin ABC

Branch

bip21-qr-codes

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33240
Build 65963: Build Diff	cashtab-tests
Build 65962: arc lint + arc unit

Event Timeline

bytesofman created this revision.Wed, May 7, 14:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, May 7, 14:00

Harbormaster completed remote builds in B33237: Diff 53891.Wed, May 7, 14:05

add tests

Harbormaster completed remote builds in B33240: Diff 53895.Wed, May 7, 17:18

bytesofman published this revision for review.Wed, May 7, 17:19

bytesofman edited the summary of this revision. (Show Details)

bytesofman edited the test plan for this revision. (Show Details)

@bot preview-cashtab

cashtab/src/components/Common/Buttons.tsx
162	? why would you want a boolean to be nullable ?
cashtab/src/components/Receive/Receive.tsx
1

This revision now requires changes to proceed.Thu, May 8, 10:13

@bot preview-cashtab

teamcity awarded a token.Thu, May 8, 10:15

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.83.66.92:41822 for the next 60 minutes.

teamcity updated a token.Thu, May 8, 10:19

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.68.37.192:41715 for the next 60 minutes.

Can we have the unit in the amount input field ? IMO it avoids confusion better than the icon only, and 10 XEC is very different from 10 FIRMA

If you input a large enough number Cashtab crashes with a WSOD and spits out a range error on console. Not a big issue but rather unsightly. The other send amount inputs throughout the app gracefully spits out a Unable to parse sendAmount as a number UI error instead of sharting.

cashtab/src/components/Receive/QRCode.tsx
123	what if `address` is neither bip21, nor token nor addressOnly types? Is the validation being done elsewhere?

bytesofman marked 3 inline comments as done.Thu, May 8, 13:54

bytesofman added inline comments.

cashtab/src/components/Common/Buttons.tsx
162	it wouldn't really make sense for the user to specify `false`, tho they could. In this case it's because `bool` is the most effective type for the purpose of this param, but we want it to default to false. So in practice, the user --- in this case, a react dev on Cashtab -- either specifies `showToast` or does not. If it is unspecified, the component defaults to `false` below. It's a common react convention. In this way, you can specify `<CopyIconButton showToast/>` and you will get this as `true`, no need for `showToast={true}`
cashtab/src/components/Receive/QRCode.tsx
123	the only user-input field is quantity, which is validated (must be a number, only 1 decimal place, decimal place must be '.', etc) The string itself is built programmatically in the component. So, right now, the only possible options are bip21 firma token + qty and bip21 xec address (optional qty). It probably is possible to get `isBip21` as `true` with bad input in the field. But in this case, it just means the user display would be `bip21 query string copied to clipboard` instead of the much longer actual string. imo it's ok to copy paste "bad" strings like this ... I guess we could disable it on validation error. But Cashtab and electrum already validate bip21 strings, so would see it there.