Paths

Table of Contentst

Differential D18117

[ecash-lib] Add `PkcAlgo` to verify common elliptic curve and RSA signatures
ClosedPublic
Actions

Authored by tobias_ruck on Tue, May 20, 12:40.

Tags

None

Subscribers

None

Details

Reviewers

Fabien
bytesofman

Group Reviewers

Restricted Project

Commits

rABCaf085ec01ace: [ecash-lib] Add `PkcAlgo` to verify common elliptic curve and RSA signatures

Summary

This allows us to verify signatures of X509 certificates, which is important for BIP70.

We use the ring crate to verify signatures in WebAssembly. On GitHub, it says that it is "an experiment", but the crate has been around for 10 years and seems to be very widely used, and it also works very well with WASM.

Keys are generated with a bash script genkeys.sh via openssl to assert we stay compatible with it. Generated keys are committed in the repo to ease debugging and reproducibility, if needed.

This increases the bundle size of CashTab by 28.73kB after gzip, which is very reasonable.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tobias_ruck created this revision.Tue, May 20, 12:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, May 20, 12:40

tobias_ruck requested review of this revision.Tue, May 20, 12:40

tobias_ruck retitled this revision from [ecash-lib] Add `PkcAlgo` to verify common clliptic curve and RSA signatures to [ecash-lib] Add `PkcAlgo` to verify common elliptic curve and RSA signatures.Tue, May 20, 12:41

wait for build

Harbormaster completed remote builds in B33382: Diff 54099.Tue, May 20, 12:56

tobias_ruck requested review of this revision.Tue, May 20, 13:00

Fabien edited the summary of this revision. (Show Details)Tue, May 20, 13:09

Fabien requested changes to this revision.Tue, May 20, 13:22

Fabien added inline comments.

modules/ecash-lib/genkeys.sh
5 ↗	(On Diff #54099)	also this should be on top
modules/ecash-lib/src/publicKeyCrypto.test.ts
1 ↗	(On Diff #54099)
23 ↗	(On Diff #54099)	does this work if not run from the current dir ?
37 ↗	(On Diff #54099)	style nit: you could group in a associative array oid => name for readability, and loop
modules/ecash-lib/src/publicKeyCrypto.ts
1 ↗	(On Diff #54099)	not repeating because it gets boring

This revision now requires changes to proceed.Tue, May 20, 13:22

tobias_ruck added inline comments.Tue, May 20, 14:06

modules/ecash-lib/genkeys.sh
5 ↗	(On Diff #54099)	2025 Can't be on top, but I can move the LC_ALL down
modules/ecash-lib/src/publicKeyCrypto.test.ts
1 ↗	(On Diff #54099)	2025
23 ↗	(On Diff #54099)	yes, and current dir is `/modules/ecash-lib`
37 ↗	(On Diff #54099)	hmm, but what's the advantage of that? seems like it's just reformatting the same thing also this way we get a nice clean error with the offending line
modules/ecash-lib/src/publicKeyCrypto.ts
1 ↗	(On Diff #54099)	computers repeat the same thing billions of times per second and it doesn't get boring for them 🤔

It's the current year!

Also move copyright notice up a bit

Harbormaster completed remote builds in B33384: Diff 54101.Tue, May 20, 14:24

Fabien accepted this revision.Tue, May 20, 14:27

Fabien added inline comments.

modules/ecash-lib/src/publicKeyCrypto.ts
1 ↗	(On Diff #54099)	The only conclusion is that I'm not a computer. I hope you're not disappointed.

This revision is now accepted and ready to land.Tue, May 20, 14:27

tobias_ruck edited the summary of this revision. (Show Details)Tue, May 20, 14:29

fix + add comments

Harbormaster completed remote builds in B33386: Diff 54103.Tue, May 20, 15:00

Closed by commit rABCaf085ec01ace: [ecash-lib] Add `PkcAlgo` to verify common elliptic curve and RSA signatures (authored by tobias_ruck). · Explain WhyTue, May 20, 15:56

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABCaf085ec01ace: [ecash-lib] Add `PkcAlgo` to verify common elliptic curve and RSA signatures.

Revision Contents
Changeset List

Path

Size

modules/

ecash-lib-wasm/

3 lines

src/

1 line

public_key_crypto.rs

122 lines

ecash-lib/

2 lines

68 lines

src/

10 lines

7 lines

payment/

8 lines

6 lines

publicKeyCrypto.test.ts

173 lines

publicKeyCrypto.ts

62 lines

testkeys/

1 line

prime256v1-cert-sha256.pem

16 lines

prime256v1-cert-sha384.pem

16 lines

prime256v1-pk.hex

1 line

prime256v1-sig-sha256.hex

1 line

prime256v1-sig-sha384.hex

1 line

prime256v1-sk.pem

8 lines

rsa2048-cert-sha256.pem

25 lines

rsa2048-cert-sha384.pem

25 lines

rsa2048-cert-sha512.pem

25 lines

rsa2048-sig-sha256.hex

1 line

rsa2048-sig-sha384.hex

1 line

rsa2048-sig-sha512.hex

1 line

28 lines

rsa3072-cert-sha256.pem

30 lines

rsa3072-cert-sha384.pem

30 lines

rsa3072-cert-sha512.pem

30 lines

rsa3072-sig-sha256.hex

1 line

rsa3072-sig-sha384.hex

1 line

rsa3072-sig-sha512.hex

1 line

40 lines

rsa4096-cert-sha256.pem

35 lines

rsa4096-cert-sha384.pem

35 lines

rsa4096-cert-sha512.pem

35 lines

rsa4096-sig-sha256.hex

1 line

rsa4096-sig-sha384.hex

1 line

rsa4096-sig-sha512.hex

1 line

52 lines

rsa8192-cert-sha256.pem

57 lines

rsa8192-cert-sha384.pem

57 lines

rsa8192-cert-sha512.pem

57 lines

rsa8192-sig-sha256.hex

1 line

rsa8192-sig-sha384.hex

1 line

rsa8192-sig-sha512.hex

1 line

100 lines

secp384r1-cert-sha256.pem

18 lines

secp384r1-cert-sha384.pem

18 lines

secp384r1-pk.hex

1 line

secp384r1-sig-sha256.hex

1 line

secp384r1-sig-sha384.hex

1 line

secp384r1-sk.pem

9 lines

Diff 54104

Cargo.lock

Loading...

modules/ecash-lib-wasm/Cargo.toml

Loading...

modules/ecash-lib-wasm/src/lib.rs

Loading...

modules/ecash-lib-wasm/src/public_key_crypto.rs

Loading...

modules/ecash-lib/.npmignore

Loading...

modules/ecash-lib/genkeys.sh

Loading...

modules/ecash-lib/src/initBrowser.ts

Loading...

modules/ecash-lib/src/initNodeJs.ts

Loading...

modules/ecash-lib/src/payment/asn1.test.ts

Loading...

modules/ecash-lib/src/payment/x509.ts

Loading...

modules/ecash-lib/src/publicKeyCrypto.test.ts

Loading...

modules/ecash-lib/src/publicKeyCrypto.ts

Loading...

modules/ecash-lib/testkeys/msg.txt

Loading...

modules/ecash-lib/testkeys/prime256v1-cert-sha256.pem

Loading...

modules/ecash-lib/testkeys/prime256v1-cert-sha384.pem

Loading...

modules/ecash-lib/testkeys/prime256v1-pk.hex

Loading...

modules/ecash-lib/testkeys/prime256v1-sig-sha256.hex

Loading...

modules/ecash-lib/testkeys/prime256v1-sig-sha384.hex

Loading...

modules/ecash-lib/testkeys/prime256v1-sk.pem

Loading...

modules/ecash-lib/testkeys/rsa2048-cert-sha256.pem

Loading...

modules/ecash-lib/testkeys/rsa2048-cert-sha384.pem

Loading...

modules/ecash-lib/testkeys/rsa2048-cert-sha512.pem

Loading...

modules/ecash-lib/testkeys/rsa2048-pk.der

Loading...

modules/ecash-lib/testkeys/rsa2048-sig-sha256.hex

Loading...

modules/ecash-lib/testkeys/rsa2048-sig-sha384.hex

Loading...

modules/ecash-lib/testkeys/rsa2048-sig-sha512.hex

Loading...

modules/ecash-lib/testkeys/rsa2048-sk.pem

Loading...

modules/ecash-lib/testkeys/rsa3072-cert-sha256.pem

Loading...

modules/ecash-lib/testkeys/rsa3072-cert-sha384.pem

Loading...

modules/ecash-lib/testkeys/rsa3072-cert-sha512.pem

Loading...

modules/ecash-lib/testkeys/rsa3072-pk.der

Loading...

modules/ecash-lib/testkeys/rsa3072-sig-sha256.hex

Loading...

modules/ecash-lib/testkeys/rsa3072-sig-sha384.hex

Loading...

modules/ecash-lib/testkeys/rsa3072-sig-sha512.hex

Loading...

modules/ecash-lib/testkeys/rsa3072-sk.pem

Loading...

modules/ecash-lib/testkeys/rsa4096-cert-sha256.pem

Loading...

modules/ecash-lib/testkeys/rsa4096-cert-sha384.pem

Loading...

modules/ecash-lib/testkeys/rsa4096-cert-sha512.pem

Loading...

modules/ecash-lib/testkeys/rsa4096-pk.der

Loading...

modules/ecash-lib/testkeys/rsa4096-sig-sha256.hex

Loading...

modules/ecash-lib/testkeys/rsa4096-sig-sha384.hex

Loading...

modules/ecash-lib/testkeys/rsa4096-sig-sha512.hex

Loading...

modules/ecash-lib/testkeys/rsa4096-sk.pem

Loading...

modules/ecash-lib/testkeys/rsa8192-cert-sha256.pem

Loading...

modules/ecash-lib/testkeys/rsa8192-cert-sha384.pem

Loading...

modules/ecash-lib/testkeys/rsa8192-cert-sha512.pem

Loading...

modules/ecash-lib/testkeys/rsa8192-pk.der

Loading...

modules/ecash-lib/testkeys/rsa8192-sig-sha256.hex

Loading...

modules/ecash-lib/testkeys/rsa8192-sig-sha384.hex

Loading...

modules/ecash-lib/testkeys/rsa8192-sig-sha512.hex

Loading...

modules/ecash-lib/testkeys/rsa8192-sk.pem

Loading...

modules/ecash-lib/testkeys/secp384r1-cert-sha256.pem

Loading...

modules/ecash-lib/testkeys/secp384r1-cert-sha384.pem

Loading...

modules/ecash-lib/testkeys/secp384r1-pk.hex

Loading...

modules/ecash-lib/testkeys/secp384r1-sig-sha256.hex

Loading...

modules/ecash-lib/testkeys/secp384r1-sig-sha384.hex

Loading...

modules/ecash-lib/testkeys/secp384r1-sk.pem

Loading...