Page MenuHomePhabricator

qt: Avoid potential -Wdeprecated-enum-enum-conversion warnings
ClosedPublic

Authored by PiRK on May 24 2025, 14:49.

Details

Summary

Use human-readable strings in preference to hard-coded integers

This is recommended by Qt docs.
See: https://doc.qt.io/qt-5/qkeysequence.html#details

Also this change avoids -Wdeprecated-enum-enum-conversion warnings.

Backport note: these deprecations become errors with Qt6

This is a backport of core#24624

Test Plan

ninja all check-all

Run bitcoin-qt, check a few of the keyboard shortcuts (open network dialog, minimize window...)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.May 24 2025, 14:49
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/transactionview.cpp
596 ↗(On Diff #54156)

Unrelated but part of the source material

This revision is now accepted and ready to land.May 26 2025, 09:18