Paths

Table of Contentst

Differential D18139

qt: Remove `QApplication::globalStrut()` call
ClosedPublic
Actions

Authored by PiRK on May 24 2025, 15:35.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCcdc0de237e20: qt: Remove `QApplication::globalStrut()` call

Summary

This function has been deprecated in Qt 5.15.0, and has been removed in
Qt 6 (see 033d01bd6e2aef740ad1408a04d3ca0ae3b9ba9b upstream commit).

This is a backport of core#579

Depends on D18138

Test Plan

ninja all check-all

Run bitcoin-qt, observe that nothing absurd happens to the Amount field (Send tab)

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33420
Build 66319: Build Diff	build-debug · lint-circular-dependencies · build-without-wallet · build-clang-tidy · build-clang · build-diff
Build 66318: arc lint + arc unit

Event Timeline

PiRK created this revision.May 24 2025, 15:35

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 24 2025, 15:35

PiRK requested review of this revision.May 24 2025, 15:35

teamcity edited the summary of this revision. (Show Details)May 24 2025, 15:35

PiRK edited the summary of this revision. (Show Details)May 24 2025, 15:36

PiRK added a parent revision: D18138: qt: misc fixed for deprecation warnings.

PiRK added a child revision: D18140: qt: Do not use `QKeyEvent` copy constructor.May 24 2025, 15:43

Harbormaster completed remote builds in B33420: Diff 54158.May 24 2025, 15:47

Fabien accepted this revision.May 26 2025, 09:23

This revision is now accepted and ready to land.May 26 2025, 09:23

Closed by commit rABCcdc0de237e20: qt: Remove `QApplication::globalStrut()` call (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyMay 26 2025, 09:53

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCcdc0de237e20: qt: Remove `QApplication::globalStrut()` call.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoinamountfield.cpp

4 lines

Diff 54158

View Options

src/qt/bitcoinamountfield.cpp

qt: Remove `QApplication::globalStrut()` callClosedPublicActions